Merge pull request #23 from mongodb-developer/fix-stored-procedures

fix stored procedures that are not working in the new schema

Author: dfreniche

docker/sample-postgres-library/init/1-library-schema-and-data.sql

@@ -139,18 +139,18 @@ ALTER FUNCTION library.generate_random_tags() OWNER TO postgres;
 -- Name: get_books_borrowed_by_user(integer); Type: FUNCTION; Schema: library; Owner: postgres
 --
 
-CREATE FUNCTION library.get_books_borrowed_by_user(user_id_param integer) RETURNS TABLE(title character varying, borrow_date timestamp without time zone, due_date timestamp without time zone, returned boolean)
-    LANGUAGE plpgsql
-    AS $$
+CREATE FUNCTION library.get_books_borrowed_by_user(user_id_param integer)
+ RETURNS TABLE(title character varying, borrow_date timestamp without time zone, due_date timestamp without time zone, returned boolean)
+ LANGUAGE plpgsql
+AS $function$
 BEGIN
     RETURN QUERY
-    SELECT b.title, id.borrow_date, id.due_date, id.returned
-    FROM operations id
-    JOIN books b ON id.book_id = b.id
-    WHERE id.user_id = user_id_param;
+    SELECT b.title, ops.borrow_date, ops.due_date, ops.returned
+    FROM library.operations ops
+    JOIN library.books b ON ops.book_id = b.id
+    WHERE ops.user_id = user_id_param;
 END;
-$$;
-
+$function$;
 
 ALTER FUNCTION library.get_books_borrowed_by_user(user_id_param integer) OWNER TO postgres;
 
@@ -159,12 +159,19 @@ ALTER FUNCTION library.get_books_borrowed_by_user(user_id_param integer) OWNER T
 -- Name: get_books_by_author(integer); Type: FUNCTION; Schema: library; Owner: postgres
 --
 
-CREATE FUNCTION library.get_books_by_author(author_id integer) RETURNS TABLE(id character varying, title character varying, pages integer, year integer, synopsis character varying, cover character varying, "totalInventory" integer, available integer, binding character varying, language character varying, publisher character varying, "longTitle" character varying, "bookOfTheMonth" boolean)
-    LANGUAGE sql
-    AS $$SELECT * FROM books
-WHERE id IN 
-	(SELECT book_id from author_book
-	WHERE author_id = 2)$$;
+CREATE FUNCTION library.get_books_by_author(author_id_param integer)
+ RETURNS SETOF library.books
+ LANGUAGE plpgsql
+AS $function$
+BEGIN
+    RETURN QUERY
+	SELECT * FROM library.books b 
+	WHERE b.id IN (
+	SELECT ab.book_id
+	FROM library.author_book ab 
+	WHERE ab.author_id = author_id_param);
+END
+$function$;
 
 
 ALTER FUNCTION library.get_books_by_author(author_id integer) OWNER TO postgres;
@@ -174,17 +181,22 @@ ALTER FUNCTION library.get_books_by_author(author_id integer) OWNER TO postgres;
 -- Name: get_books_by_genre(character varying); Type: FUNCTION; Schema: library; Owner: postgres
 --
 
-CREATE FUNCTION library.get_books_by_genre(genre_param character varying) RETURNS TABLE(title character varying)
-    LANGUAGE plpgsql
-    AS $$
+CREATE FUNCTION library.get_books_by_genre(genre_param character varying)
+ RETURNS TABLE(title character varying)
+ LANGUAGE plpgsql
+AS $function$
 BEGIN
     RETURN QUERY
-    SELECT b.title
-    FROM books b
-    JOIN book_genre bg ON b.id = bg.book_id
-    WHERE bg.genre = genre_param;
+	SELECT b.title 
+  	FROM library.books b
+  	WHERE b.id IN (
+  	SELECT bg.book_id
+  	FROM library.book_genre bg
+  	JOIN library.genres g ON bg.genre_id = g.id
+  	WHERE g.name = genre_param
+  );
 END;
-$$;
+$function$;
 
 
 ALTER FUNCTION library.get_books_by_genre(genre_param character varying) OWNER TO postgres;

docs/210-Generate code/40-testing-queries.mdx

@@ -35,20 +35,13 @@ Relation Migrator allows you to go a step further, and verify the converted quer
     <Screenshot url="http://127.0.0.1:8278" src="img/testing-queries-005.png" alt="Screenshot to show result comparison" />
 5. If the query results are different, check your MongoDB query. In this example, your MongoDB query should look like:
     ```js
-        async function get_books_by_genre(db, genre_param) {
-        const result = await db.collection('books').aggregate([
-            {
-                $match: {
-                    'genre': genre_param
-                }
-            },
-            {
-                $project: {
-                    title: 1
-                }
-            }
-        ]).toArray();
-            return result;
+        async function library_get_books_by_genre(db, genre_param) {
+            const books = await db.collection('books').aggregate([
+                { $match: { 'genres.name': genre_param } },
+                { $project: { title: 1 }}
+            ]).toArray();
+            
+            return books.map(book => ({ title: book.title }));
         }
     ```
     Also check that any changes your made to your MongoDB query are saved.