Address memory leaks in test suite (#903)

Author: eramongodb

test/test-mc-fle2-payload-iup-v2.c

@@ -238,6 +238,8 @@ static void _test_mc_FLE2InsertUpdatePayloadV2_parses_crypto_params(_mongocrypt_
 
     ASSERT(got.indexMax.value_type == BSON_TYPE_INT32);
     ASSERT_CMPINT32(got.indexMax.value.v_int32, ==, 1234567);
+
+    mc_FLE2InsertUpdatePayloadV2_cleanup(&got);
 }
 
 void _mongocrypt_tester_install_fle2_payload_iup_v2(_mongocrypt_tester_t *tester) {

test/test-mc-range-mincover.c

@@ -85,7 +85,7 @@ typedef struct {
 
 typedef struct _test_getMincover_args {
     mc_mincover_t *(*getMincover)(void *tests, size_t idx, mongocrypt_status_t *status);
-    const char *(*expectError)(void *tests, size_t idx);
+    const char *(*expectError)(void *tests, size_t idx, mongocrypt_status_t *status);
     const char *const *(*expectMincoverStrings)(void *tests, size_t idx);
     void (*dump)(void *tests, size_t idx, mc_mincover_t *got);
 } _test_getMincover_args;
@@ -171,23 +171,25 @@ static mc_mincover_t *_test_getMincoverDecimal128_helper(void *tests, size_t idx
 }
 #endif // MONGOCRYPT_HAVE_DECIMAL128_SUPPORT
 
-static const char *_test_expectError32(void *tests, size_t idx) {
+static const char *_test_expectError32(void *tests, size_t idx, mongocrypt_status_t *status) {
     BSON_ASSERT_PARAM(tests);
+    BSON_ASSERT_PARAM(status);
     return ((Int32Test *)tests + idx)->expectError;
 }
 
-static const char *_test_expectError64(void *tests, size_t idx) {
+static const char *_test_expectError64(void *tests, size_t idx, mongocrypt_status_t *status) {
     BSON_ASSERT_PARAM(tests);
+    BSON_ASSERT_PARAM(status);
     return ((Int64Test *)tests + idx)->expectError;
 }
 
-static const char *_test_expectErrorDouble(void *tests, size_t idx) {
+static const char *_test_expectErrorDouble(void *tests, size_t idx, mongocrypt_status_t *status) {
     BSON_ASSERT_PARAM(tests);
+    BSON_ASSERT_PARAM(status);
     DoubleTest *test = ((DoubleTest *)tests + idx);
     if (test->min.set && test->max.set && test->precision.set) {
         // Expect an error for tests including an invalid min/max/precision.
         uint32_t ignored;
-        mongocrypt_status_t *const status = mongocrypt_status_new();
         if (!mc_canUsePrecisionModeDouble(test->min.value, test->max.value, test->precision.value, &ignored, status)) {
             if (!mongocrypt_status_ok(status)) {
                 return mongocrypt_status_message(status, NULL);
@@ -196,19 +198,18 @@ static const char *_test_expectErrorDouble(void *tests, size_t idx) {
             return "The domain of double values specified by the min, max, and precision cannot be represented in "
                    "fewer than 64 bits";
         }
-        mongocrypt_status_destroy(status);
     }
     return test->expectError;
 }
 
 #if MONGOCRYPT_HAVE_DECIMAL128_SUPPORT
-static const char *_test_expectErrorDecimal128(void *tests, size_t idx) {
+static const char *_test_expectErrorDecimal128(void *tests, size_t idx, mongocrypt_status_t *status) {
     BSON_ASSERT_PARAM(tests);
+    BSON_ASSERT_PARAM(status);
     Decimal128Test *test = ((Decimal128Test *)tests + idx);
     if (test->min.set && test->max.set && test->precision.set) {
         // Expect an error for tests including an invalid min/max/precision.
         uint32_t ignored;
-        mongocrypt_status_t *const status = mongocrypt_status_new();
         if (!mc_canUsePrecisionModeDecimal(test->min.value, test->max.value, test->precision.value, &ignored, status)) {
             if (!mongocrypt_status_ok(status)) {
                 return mongocrypt_status_message(status, NULL);
@@ -374,7 +375,7 @@ static void _test_getMincover_impl(void *tests, size_t num_tests, _test_getMinco
     for (size_t i = 0; i < num_tests; i++) {
         mongocrypt_status_t *const status = mongocrypt_status_new();
         mc_mincover_t *got = args.getMincover(tests, i, status);
-        const char *expectError = args.expectError(tests, i);
+        const char *expectError = args.expectError(tests, i, status);
         if (expectError) {
             ASSERT_OR_PRINT_MSG(NULL == got, "expected error, got success");
             ASSERT_STATUS_CONTAINS(status, expectError);

test/test-mongocrypt-ctx-rewrap-many-datakey.c

@@ -571,6 +571,7 @@ static void _test_rewrap_many_datakey_need_kms_retry(_mongocrypt_tester_t *teste
     ASSERT_OK(mongocrypt_ctx_kms_done(ctx), ctx);
     ASSERT_STATE_EQUAL(mongocrypt_ctx_state(ctx), MONGOCRYPT_CTX_NEED_KMS); // To encrypt.
     mongocrypt_ctx_destroy(ctx);
+    mongocrypt_destroy(crypt);
 }
 
 static void _test_rewrap_many_datakey_need_kms_encrypt(_mongocrypt_tester_t *tester) {