Skip to content

Commit ba81027

Browse files
committed
Small corrections according to PR
1 parent 4723bea commit ba81027

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

Diff for: src/MongoDB.Driver/Search/SearchPathDefinition.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -105,11 +105,11 @@ public static implicit operator SearchPathDefinition<TDocument>(List<string> fie
105105
/// <param name="args">The render arguments.</param>
106106
/// <returns>The rendered field.</returns>
107107
protected string RenderField(FieldDefinition<TDocument> fieldDefinition, RenderArgs<TDocument> args)
108-
=> RenderFieldWithSerializer(fieldDefinition, args).renderedPath;
108+
=> RenderFieldAndGetFieldSerializer(fieldDefinition, args).renderedPath;
109109

110110
internal virtual (BsonValue, IBsonSerializer) RenderAndGetFieldSerializer(RenderArgs<TDocument> args) => (Render(args), null);
111111

112-
internal (string renderedPath, IBsonSerializer fieldSerializer) RenderFieldWithSerializer(FieldDefinition<TDocument> fieldDefinition, RenderArgs<TDocument> args)
112+
internal (string renderedPath, IBsonSerializer fieldSerializer) RenderFieldAndGetFieldSerializer(FieldDefinition<TDocument> fieldDefinition, RenderArgs<TDocument> args)
113113
{
114114
var renderedField = fieldDefinition.Render(args);
115115
var prefix = args.PathRenderArgs.PathPrefix;

Diff for: src/MongoDB.Driver/Search/SearchPathDefinitionBuilder.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ public override BsonValue Render(RenderArgs<TDocument> args) =>
147147
RenderField(_field, args);
148148

149149
internal override (BsonValue, IBsonSerializer) RenderAndGetFieldSerializer(RenderArgs<TDocument> args)
150-
=> RenderFieldWithSerializer(_field, args);
150+
=> RenderFieldAndGetFieldSerializer(_field, args);
151151
}
152152

153153
internal sealed class WildcardSearchPathDefinition<TDocument> : SearchPathDefinition<TDocument>

Diff for: tests/MongoDB.Driver.Tests/Search/SearchDefinitionBuilderTests.cs

+2-1
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,8 @@ public void Equals_should_render_supported_type<T>(
288288
var subject = CreateSubject<BsonDocument>();
289289
var subjectTyped = CreateSubject<Person>();
290290

291-
//There is no property called "x" where to pick up a properly configured GuidSerializer for the tests
291+
//When using an untyped query, the default GuidSerializer is used, and that will throw an exception
292+
//because the GuidRepresentation is Unspecified.
292293
if (typeof(T) != typeof(Guid))
293294
{
294295
AssertRendered(

0 commit comments

Comments
 (0)