Skip to content

Commit 0f1f8a7

Browse files
committed
Move test case to separate test
1 parent 66d045e commit 0f1f8a7

File tree

2 files changed

+22
-12
lines changed

2 files changed

+22
-12
lines changed

test/asynchronous/test_dns.py

+11-6
Original file line numberDiff line numberDiff line change
@@ -267,12 +267,6 @@ async def test_3_throw_when_return_address_is_identical_to_srv_hostname(self):
267267
"mock_target": "mongo.local",
268268
"expected_error": "Invalid SRV host",
269269
},
270-
# When the SRV hostname has three or more dot-separated parts
271-
# it is valid for the returned hostnames to be identical.
272-
{
273-
"query": "_mongodb._tcp.blogs.mongodb.com",
274-
"mock_target": "blogs.mongodb.com",
275-
},
276270
]
277271
await self.run_initial_dns_seedlist_discovery_prose_tests(test_cases)
278272

@@ -298,6 +292,17 @@ async def test_4_throw_when_return_address_does_not_contain_dot_separating_share
298292
]
299293
await self.run_initial_dns_seedlist_discovery_prose_tests(test_cases)
300294

295+
async def test_5_when_srv_hostname_has_two_dot_separated_parts_it_is_valid_for_the_returned_hostname_to_be_identical(
296+
self
297+
):
298+
test_cases = [
299+
{
300+
"query": "_mongodb._tcp.blogs.mongodb.com",
301+
"mock_target": "blogs.mongodb.com",
302+
},
303+
]
304+
await self.run_initial_dns_seedlist_discovery_prose_tests(test_cases)
305+
301306

302307
if __name__ == "__main__":
303308
unittest.main()

test/test_dns.py

+11-6
Original file line numberDiff line numberDiff line change
@@ -265,12 +265,6 @@ def test_3_throw_when_return_address_is_identical_to_srv_hostname(self):
265265
"mock_target": "mongo.local",
266266
"expected_error": "Invalid SRV host",
267267
},
268-
# When the SRV hostname has three or more dot-separated parts
269-
# it is valid for the returned hostnames to be identical.
270-
{
271-
"query": "_mongodb._tcp.blogs.mongodb.com",
272-
"mock_target": "blogs.mongodb.com",
273-
},
274268
]
275269
self.run_initial_dns_seedlist_discovery_prose_tests(test_cases)
276270

@@ -296,6 +290,17 @@ def test_4_throw_when_return_address_does_not_contain_dot_separating_shared_part
296290
]
297291
self.run_initial_dns_seedlist_discovery_prose_tests(test_cases)
298292

293+
def test_5_when_srv_hostname_has_two_dot_separated_parts_it_is_valid_for_the_returned_hostname_to_be_identical(
294+
self
295+
):
296+
test_cases = [
297+
{
298+
"query": "_mongodb._tcp.blogs.mongodb.com",
299+
"mock_target": "blogs.mongodb.com",
300+
},
301+
]
302+
self.run_initial_dns_seedlist_discovery_prose_tests(test_cases)
303+
299304

300305
if __name__ == "__main__":
301306
unittest.main()

0 commit comments

Comments
 (0)