Skip to content

Commit 93ddb52

Browse files
chore: misc changes
1 parent 7acafe0 commit 93ddb52

File tree

2 files changed

+4
-11
lines changed

2 files changed

+4
-11
lines changed

src/operations/delete.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,8 @@ export class DeleteOperation extends CommandOperation<Document> {
8585
const unacknowledgedWrite = this.writeConcern && this.writeConcern.w === 0;
8686
if (unacknowledgedWrite) {
8787
if (this.statements.find((o: Document) => o.hint)) {
88-
callback(new MongoCompatibilityError(`Servers < 3.4 do not support hint on delete`));
88+
// TODO(NODE-3541): fix error for hint with unacknowledged writes
89+
callback(new MongoCompatibilityError(`hint is not supported with unacknowledged writes`));
8990
return;
9091
}
9192
}

src/operations/update.ts

+2-10
Original file line numberDiff line numberDiff line change
@@ -110,16 +110,8 @@ export class UpdateOperation extends CommandOperation<Document> {
110110
const unacknowledgedWrite = this.writeConcern && this.writeConcern.w === 0;
111111
if (unacknowledgedWrite) {
112112
if (this.statements.find((o: Document) => o.hint)) {
113-
if (maxWireVersion(server) < 5) {
114-
callback(new MongoCompatibilityError(`Servers < 3.4 do not support hint on update`));
115-
} else {
116-
// TODO: https://jira.mongodb.org/browse/NODE-3541
117-
callback(
118-
new MongoCompatibilityError(
119-
`This Node.js driver do not support hint together with unacknowledged writes`
120-
)
121-
);
122-
}
113+
// TODO(NODE-3541): fix error for hint with unacknowledged writes
114+
callback(new MongoCompatibilityError(`hint is not supported with unacknowledged writes`));
123115
return;
124116
}
125117
}

0 commit comments

Comments
 (0)