Skip to content

Commit a36535d

Browse files
chore: remove unnecessary wire version checks in update and delete
1 parent a50a22e commit a36535d

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/operations/delete.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import type { Collection } from '../collection';
33
import { MongoCompatibilityError, MongoServerError } from '../error';
44
import type { Server } from '../sdam/server';
55
import type { ClientSession } from '../sessions';
6-
import { Callback, maxWireVersion, MongoDBNamespace } from '../utils';
6+
import type { Callback, MongoDBNamespace } from '../utils';
77
import type { WriteConcernOptions } from '../write_concern';
88
import { CollationOptions, CommandOperation, CommandOperationOptions } from './command';
99
import { Aspect, defineAspects, Hint } from './operation';
@@ -83,7 +83,7 @@ export class DeleteOperation extends CommandOperation<Document> {
8383
}
8484

8585
const unacknowledgedWrite = this.writeConcern && this.writeConcern.w === 0;
86-
if (unacknowledgedWrite || maxWireVersion(server) < 5) {
86+
if (unacknowledgedWrite) {
8787
if (this.statements.find((o: Document) => o.hint)) {
8888
callback(new MongoCompatibilityError(`Servers < 3.4 do not support hint on delete`));
8989
return;

src/operations/update.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import type { Collection } from '../collection';
33
import { MongoCompatibilityError, MongoInvalidArgumentError, MongoServerError } from '../error';
44
import type { Server } from '../sdam/server';
55
import type { ClientSession } from '../sessions';
6-
import { Callback, hasAtomicOperators, maxWireVersion, MongoDBNamespace } from '../utils';
6+
import { Callback, hasAtomicOperators, MongoDBNamespace } from '../utils';
77
import { CollationOptions, CommandOperation, CommandOperationOptions } from './command';
88
import { Aspect, defineAspects, Hint } from './operation';
99

@@ -108,7 +108,7 @@ export class UpdateOperation extends CommandOperation<Document> {
108108
}
109109

110110
const unacknowledgedWrite = this.writeConcern && this.writeConcern.w === 0;
111-
if (unacknowledgedWrite || maxWireVersion(server) < 5) {
111+
if (unacknowledgedWrite) {
112112
if (this.statements.find((o: Document) => o.hint)) {
113113
callback(new MongoCompatibilityError(`Servers < 3.4 do not support hint on update`));
114114
return;

0 commit comments

Comments
 (0)