Skip to content

Commit e9de925

Browse files
chore: misc changes
1 parent 0c3fd9d commit e9de925

File tree

2 files changed

+4
-11
lines changed

2 files changed

+4
-11
lines changed

src/operations/delete.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,8 @@ export class DeleteOperation extends CommandOperation<Document> {
9393
const unacknowledgedWrite = this.writeConcern && this.writeConcern.w === 0;
9494
if (unacknowledgedWrite || maxWireVersion(server) < 5) {
9595
if (this.statements.find((o: Document) => o.hint)) {
96-
callback(new MongoCompatibilityError(`Servers < 3.4 do not support hint on delete`));
96+
// TODO(NODE-3541): fix error for hint with unacknowledged writes
97+
callback(new MongoCompatibilityError(`hint is not supported with unacknowledged writes`));
9798
return;
9899
}
99100
}

src/operations/update.ts

+2-10
Original file line numberDiff line numberDiff line change
@@ -125,16 +125,8 @@ export class UpdateOperation extends CommandOperation<Document> {
125125
const unacknowledgedWrite = this.writeConcern && this.writeConcern.w === 0;
126126
if (unacknowledgedWrite || maxWireVersion(server) < 5) {
127127
if (this.statements.find((o: Document) => o.hint)) {
128-
if (maxWireVersion(server) < 5) {
129-
callback(new MongoCompatibilityError(`Servers < 3.4 do not support hint on update`));
130-
} else {
131-
// TODO: https://jira.mongodb.org/browse/NODE-3541
132-
callback(
133-
new MongoCompatibilityError(
134-
`This Node.js driver do not support hint together with unacknowledged writes`
135-
)
136-
);
137-
}
128+
// TODO(NODE-3541): fix error for hint with unacknowledged writes
129+
callback(new MongoCompatibilityError(`hint is not supported with unacknowledged writes`));
138130
return;
139131
}
140132
}

0 commit comments

Comments
 (0)