test: Refactors custom DB role tests and adds documentation for empty database (#3294)

* refactor: Remove redundant TestAccConfigRSCustomDBRoles_MultipleResources test (running the same test 5 times, not using multiple resources as the name says)

* test: Remove duplication and add check for empty database_name

* refactor: Use data source also in resource test

* refactor: Enhance custom DB role tests with plural data source checks

* feat: Add PluralResultCheck function

* doc: Clarify database_name usage in custom DB role documentation

* refactor: Remove redundant variable declaration and update comment for PluralResultCheck

* refactor: Remove nil check for results in findResultsMatch function

Author: EspenAlbert

docs/data-sources/custom_db_role.md

@@ -53,7 +53,7 @@ Each object in the actions array represents an individual privilege action grant
 
 * `resources.#.collection_name` - (Optional) Collection on which the action is granted. If this value is an empty string, the action is granted on all collections within the database specified in the actions.resources.db field.
 
-* `resources.#.database_name`	Database on which the action is granted.
+* `resources.#.database_name` Database on which the action is granted. The empty string ("") allows an action on all databases.
 
 * `resources.#.cluster`	(Optional) Set to true to indicate that the action is granted on the cluster resource.
 

docs/data-sources/custom_db_roles.md

@@ -49,7 +49,7 @@ Each object in the actions array represents an individual privilege action grant
 
 * `resources.#.collection_name` - (Optional) Collection on which the action is granted. If this value is an empty string, the action is granted on all collections within the database specified in the actions.resources.db field.
 
-* `resources.#.database_name`	Database on which the action is granted.
+* `resources.#.database_name` Database on which the action is granted. The empty string ("") allows an action on all databases.
 
 * `resources.#.cluster`	(Optional) Set to true to indicate that the action is granted on the cluster resource.
 

docs/resources/custom_db_role.md

@@ -18,7 +18,7 @@ resource "mongodbatlas_custom_db_role" "test_role" {
     action = "UPDATE"
     resources {
       collection_name = ""
-      database_name   = "anyDatabase"
+      database_name   = "anyDatabase" # use the empty string ("") to allow an action on all databases.
     }
   }
   actions {
@@ -123,7 +123,7 @@ Each object in the actions array represents an individual privilege action grant
 
 	-> **NOTE** This field is mutually exclusive with the `actions.resources.cluster` field.
 
-* `resources.#.database_name`	Database on which the action is granted.
+* `resources.#.database_name` Database on which the action is granted. Use the empty string ("") to allow an action on all databases.
 
 	-> **NOTE** This field is mutually exclusive with the `actions.resources.cluster` field.
 

internal/service/customdbrole/data_source_custom_db_role_test.go

@@ -1,40 +1,11 @@
 package customdbrole_test
 
 import (
-	"os"
 	"testing"
 
-	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
-	"github.com/mongodb/terraform-provider-mongodbatlas/internal/testutil/acc"
 	"github.com/mongodb/terraform-provider-mongodbatlas/internal/testutil/mig"
 )
 
 func TestMigConfigCustomDBRoles_Basic(t *testing.T) {
-	var (
-		orgID        = os.Getenv("MONGODB_ATLAS_ORG_ID")
-		projectName  = acc.RandomProjectName()
-		roleName     = acc.RandomName()
-		databaseName = acc.RandomClusterName()
-		config       = configBasic(orgID, projectName, roleName, "INSERT", databaseName)
-	)
-
-	resource.ParallelTest(t, resource.TestCase{
-		PreCheck:     func() { mig.PreCheckBasic(t) },
-		CheckDestroy: checkDestroy,
-		Steps: []resource.TestStep{
-			{
-				ExternalProviders: mig.ExternalProviders(),
-				Config:            config,
-				Check: resource.ComposeAggregateTestCheckFunc(
-					checkExists(resourceName),
-					resource.TestCheckResourceAttrSet(resourceName, "project_id"),
-					resource.TestCheckResourceAttr(resourceName, "role_name", roleName),
-					resource.TestCheckResourceAttr(resourceName, "actions.#", "1"),
-					resource.TestCheckResourceAttr(resourceName, "actions.0.action", "INSERT"),
-					resource.TestCheckResourceAttr(resourceName, "actions.0.resources.#", "1"),
-				),
-			},
-			mig.TestStepCheckEmptyPlan(config),
-		},
-	})
+	mig.CreateAndRunTest(t, basicTestCase(t))
 }