skip resource policy mig test until 1.33.0

Author: AgustinBettati

internal/service/resourcepolicy/resource_migration_test.go

@@ -7,12 +7,6 @@ import (
 )
 
 func TestMigResourcePolicy_basic(t *testing.T) {
-	mig.SkipIfVersionBelow(t, "1.22.0") // this feature was introduced in provider version 1.21.0, plural data source schema was changed in 1.22.0
-
-	var description *string
-	if mig.IsProviderVersionAtLeast("1.32.0") {
-		description = descriptionPtr
-	}
-
-	mig.CreateAndRunTestNonParallel(t, basicTestCase(t, description))
+	mig.SkipIfVersionBelow(t, "1.33.0") // this feature was GA (no need of MONGODB_ATLAS_ENABLE_PREVIEW env variable) in 1.33.0
+	mig.CreateAndRunTestNonParallel(t, basicTestCase(t, descriptionPtr))
 }

internal/service/resourcepolicy/resource_test.go

@@ -52,33 +52,31 @@ var (
 		when {
 		context.project.ipAccessList.contains(ip("0.0.0.0/0"))
 	};`
-	descriptionPtr = conversion.StringPtr("test-description")
+	description = "test-description"
 )
 
 func TestAccResourcePolicy_basic(t *testing.T) {
-	tc := basicTestCase(t, descriptionPtr)
+	tc := basicTestCase(t)
 	resource.Test(t, *tc)
 }
 
-func basicTestCase(t *testing.T, description *string) *resource.TestCase {
+func basicTestCase(t *testing.T) *resource.TestCase {
 	t.Helper()
 	var (
 		orgID       = os.Getenv("MONGODB_ATLAS_ORG_ID")
 		policyName  = "test-policy"
 		updatedName = "updated-policy"
 	)
-	var updatedDescription string
-	if description != nil {
-		updatedDescription = fmt.Sprintf("updated-%s", *description)
-	}
+	updatedDescription := fmt.Sprintf("updated-%s", description)
+	
 	return &resource.TestCase{ // Need sequential execution for assertions to be deterministic (plural data source)
 		PreCheck:                 func() { acc.PreCheckBasic(t) },
 		ProtoV6ProviderFactories: acc.TestAccProviderV6Factories,
 		CheckDestroy:             checkDestroy,
 		Steps: []resource.TestStep{
 			{
-				Config: configBasic(orgID, policyName, description),
-				Check:  checksResourcePolicy(orgID, policyName, description, 1),
+				Config: configBasic(orgID, policyName, &description),
+				Check:  checksResourcePolicy(orgID, policyName, &description, 1),
 			},
 			{
 				Config: configBasic(orgID, updatedName, nil),