Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip Remains Visible After Hovering Outside of the Target Area #6320

Closed
2 tasks done
aditya-mistri opened this issue Feb 27, 2025 · 3 comments
Closed
2 tasks done
Labels
bug Something isn't working

Comments

@aditya-mistri
Copy link

Did you clear cache before opening an issue?

  • I have cleared my cache

Is there an existing issue for this?

  • I have searched the existing issues

Does the issue happen when logged in?

Yes

Does the issue happen when logged out?

Yes

Does the issue happen in incognito mode when logged in?

Yes

Does the issue happen in incognito mode when logged out?

Yes

Account name

rhonk

Account config

No response

Current Behavior

when i open the theme selector popup and select a theme , the popup closes but the tooltip [ shift click to toggle custom theme ] does not go away when hovering on rest part of the screen .
This issue is in every page except the default typing test page .

Image

Expected Behavior

The expected behavior is that when the theme is selected and the theme selector popup closes, the tooltip "Shift click to toggle custom theme" should also disappear. The tooltip should not remain visible when hovering over other parts of the screen, and it should be dismissed properly, just like it works on the default typing test page.

Steps To Reproduce

  1. Go to bottom of any page except default typing page for example : [ https://monkeytype.com/settings ]
  2. at the footer there is theme button showing current theme
  3. click the button , select any theme
  4. you can see the tooltip is there [ even when we scroll , it does not disappear ].

Image

Environment

  • OS: Windows 10
  • Browser: Brave
  • Browser Version: 1.75.180 Chromium: 133.0.6943.126 (Official Build) (64-bit)]

Anything else?

I would like to work on this issue

@aditya-mistri aditya-mistri added the bug Something isn't working label Feb 27, 2025
@Miodec
Copy link
Member

Miodec commented Mar 4, 2025

Not sure if this can be fixed. The browser will refocus the last element automatically when a modal (commandline in this case) is closed, and focused elements will always show the hover tooltip.

@VKTRenokh
Copy link

VKTRenokh commented Mar 5, 2025

The browser will refocus the last element automatically

can we just do document.activeElement.blur() on cmdline hide?
if so I can open a pr right away

@Miodec
Copy link
Member

Miodec commented Mar 5, 2025

The browser will refocus the last element automatically

can we just do document.activeElement.blur() on cmdline hide?

Oh yeah, that actually works - it hides the focus border and keeps the focus order. Thanks.

@Miodec Miodec closed this as completed in 25dada5 Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants