Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language): Remove nekudos from Yiddish file (@isaacweber613) #6321

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

isaacweber613
Copy link

@isaacweber613 isaacweber613 commented Feb 27, 2025

Description

Removed all nekudos (diacritics) from the Yiddish language file becuase when you type in yiddish you usually don't type with nekudos and if yes you add them later so you don't want it when practicing to type.

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Feb 27, 2025
@LazerDoubleU
Copy link

I agree that we don't need nekudos when typing in Hebrew most of time, maybe it should be a setting to turn it on or off.

@Miodec
Copy link
Member

Miodec commented Mar 3, 2025

Instead of removing these from the word list, you should edit the frontend/src/ts/test/lazy-mode.ts file and add a ll the accents and their non accented versions. Also, remove noLazyMode from the list file.

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Mar 3, 2025
@isaacweber613
Copy link
Author

Instead of removing these from the word list, you should edit the frontend/src/ts/test/lazy-mode.ts file and add a ll the accents and their non accented versions. Also, remove noLazyMode from the list file.

Hey, thanks for the feedback!
I get why other languages handle diacritics in lazy-mode.ts, but Yiddish is different. Yiddish is almost never written with nekudos in real life—they're mainly used for educational or religious texts, not everyday writing. Keeping them in the JSON and stripping them dynamically just adds extra processing for no reason.
The best solution is to remove the nekudos from the word list entirely, since that’s how Yiddish is actually written. This keeps things simple, accurate, and closer to what native speakers expect.
besides I'm not good at coding and don't know how to do this.

@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants