Move parameter validation to a function

Author: junpataleta

tracker_automations/continuous_manage_queues/continuous_manage_queues.sh

@@ -72,27 +72,10 @@ movemax=${movemax:-3}
 lastweekdate=${lastweekdate:-$(date -d "${releasedate} -7day" +%Y-%m-%d)}
 dryrun=${dryrun:-}
 
-# Verify that $releasedate has a correct YYYY-MM-DD format
-if [[ ! ${releasedate} =~ ^[0-9]{4}-[0-9]{2}-[0-9]{2}$ ]]; then
-    echo "ERROR: \$releasedate. Incorrect YYYY-MM-DD format detected: ${releasedate}"
-    exit 1
-fi
-
-# Verify that $lastweekdate has a correct YYYY-MM-DD format
-if [[ ! ${lastweekdate} =~ ^[0-9]{4}-[0-9]{2}-[0-9]{2}$ ]]; then
-    echo "ERROR: \$lastweekdate. Incorrect YYYY-MM-DD format detected: ${lastweekdate}"
-    exit 1
-fi
-
 # Today
 nowdate=$(date +%Y%m%d)
 
-# Verify that the current date is not well past the on-sync period. (Normally 2 weeks but making it 4 weeks just in case).
-onsyncenddate=$(date -d "${releasedate} +28day" +%Y%m%d)
-if [ $nowdate -gt $onsyncenddate ]; then
-    echo "ERROR: The current date is already past the on-sync period. Please make sure the Release date ($releasedate) is configured correctly."
-    exit 1
-fi
+run_param_validation $releasedate $lastweekdate
 
 # Decide if we are going to proceed with behaviour A (before release) or behaviour B (after release)
 behaviorAB=

tracker_automations/continuous_manage_queues/lib.sh

@@ -389,3 +389,30 @@ function run_C() {
         echo "$BUILD_NUMBER $BUILD_TIMESTAMP ${issue} moved out from current: held" >> "${logfile}"
     done
 }
+
+function run_param_validation() {
+    nowdate=$(date +%Y%m%d)
+    releasedate=$1
+    lastweekdate=${2:-$(date -d "${releasedate} -7day" +%Y-%m-%d)}
+
+    # Verify that $releasedate has a correct YYYY-MM-DD format
+    if [[ ! ${releasedate} =~ ^[0-9]{4}-[0-9]{2}-[0-9]{2}$ ]]; then
+        echo "ERROR: \$releasedate. Incorrect YYYY-MM-DD format detected: ${releasedate}"
+        return 1
+    fi
+
+    # Verify that $lastweekdate has a correct YYYY-MM-DD format
+    if [[ ! ${lastweekdate} =~ ^[0-9]{4}-[0-9]{2}-[0-9]{2}$ ]]; then
+        echo "ERROR: \$lastweekdate. Incorrect YYYY-MM-DD format detected: ${lastweekdate}"
+        return 1
+    fi
+
+    # Verify that the current date is not well past the on-sync period. (Normally 2 weeks but making it 4 weeks just in case).
+    onsyncenddate=$(date -d "${releasedate} +28day" +%Y%m%d)
+    if [ $nowdate -gt $onsyncenddate ]; then
+        echo "ERROR: The current date is already past the on-sync period. Please make sure the Release date ($releasedate) is configured correctly."
+        return 1
+    fi
+
+    echo "Parameters validated."
+}