MOBILE-3671 assign: Move constants

Author: crazyserver

src/addons/mod/assign/assign.module.ts

@@ -23,15 +23,15 @@ import { CorePushNotificationsDelegate } from '@features/pushnotifications/servi
 import { CoreCronDelegate } from '@services/cron';
 import { CORE_SITE_SCHEMAS } from '@services/sites';
 import { AddonModAssignFeedbackModule } from './feedback/feedback.module';
-import { OFFLINE_SITE_SCHEMA } from './services/database/assign';
+import { ADDON_MOD_ASSIGN_OFFLINE_SITE_SCHEMA } from './services/database/assign';
 import { AddonModAssignIndexLinkHandler } from './services/handlers/index-link';
 import { AddonModAssignListLinkHandler } from './services/handlers/list-link';
 import { AddonModAssignModuleHandler } from './services/handlers/module';
 import { AddonModAssignPrefetchHandler } from './services/handlers/prefetch';
 import { AddonModAssignPushClickHandler } from './services/handlers/push-click';
 import { AddonModAssignSyncCronHandler } from './services/handlers/sync-cron';
 import { AddonModAssignSubmissionModule } from './submission/submission.module';
-import { ADDON_MOD_ASSIGN_COMPONENT, ADDON_MOD_ASSIGN_PAGE_NAME } from './constants';
+import { ADDON_MOD_ASSIGN_COMPONENT_LEGACY, ADDON_MOD_ASSIGN_PAGE_NAME } from './constants';
 import { conditionalRoutes } from '@/app/app-routing.module';
 import { canLeaveGuard } from '@guards/can-leave';
 import { CoreScreen } from '@services/screen';
@@ -133,7 +133,7 @@ const routes: Routes = [
     providers: [
         {
             provide: CORE_SITE_SCHEMAS,
-            useValue: [OFFLINE_SITE_SCHEMA],
+            useValue: [ADDON_MOD_ASSIGN_OFFLINE_SITE_SCHEMA],
             multi: true,
         },
         {
@@ -147,7 +147,7 @@ const routes: Routes = [
                 CoreCronDelegate.register(AddonModAssignSyncCronHandler.instance);
                 CorePushNotificationsDelegate.registerClickHandler(AddonModAssignPushClickHandler.instance);
 
-                CoreCourseHelper.registerModuleReminderClick(ADDON_MOD_ASSIGN_COMPONENT);
+                CoreCourseHelper.registerModuleReminderClick(ADDON_MOD_ASSIGN_COMPONENT_LEGACY);
             },
         },
     ],

src/addons/mod/assign/classes/submissions-source.ts

@@ -23,14 +23,17 @@ import { CoreEvents } from '@singletons/events';
 import {
     AddonModAssign,
     AddonModAssignAssign,
-    AddonModAssignGradingStates,
     AddonModAssignSubmission,
-    AddonModAssignSubmissionStatusValues,
 } from '../services/assign';
 import { AddonModAssignHelper, AddonModAssignSubmissionFormatted } from '../services/assign-helper';
 import { AddonModAssignOffline } from '../services/assign-offline';
 import { AddonModAssignSync } from '../services/assign-sync';
-import { ADDON_MOD_ASSIGN_MANUAL_SYNCED } from '../constants';
+import {
+    ADDON_MOD_ASSIGN_MANUAL_SYNCED,
+    AddonModAssignGradingStates,
+    AddonModAssignListFilterName,
+    AddonModAssignSubmissionStatusValues,
+} from '../constants';
 
 /**
  * Provides a collection of assignment submissions.
@@ -256,13 +259,3 @@ export type AddonModAssignSubmissionForList = AddonModAssignSubmissionFormatted
     gradingStatusTranslationId?: string; // Calculated in the app. Key of the text of the submission grading status.
     needsGrading?: boolean; // Calculated in the app. If submission and grading status means that it needs grading.
 };
-
-/**
- * List filter by status name.
- */
-export enum AddonModAssignListFilterName {
-    ALL = '',
-    NEED_GRADING = 'needgrading',
-    DRAFT = 'draft',
-    SUBMITTED = 'submitted',
-}

src/addons/mod/assign/components/edit-feedback-modal/edit-feedback-modal.ts

@@ -17,8 +17,6 @@ import { ModalController, Translate } from '@singletons';
 import {
     AddonModAssign,
     AddonModAssignAssign,
-    AddonModAssignAttemptReopenMethodValues,
-    AddonModAssignGradingStates,
     AddonModAssignSavePluginData,
     AddonModAssignSubmissionFeedback,
 } from '../../services/assign';
@@ -30,6 +28,8 @@ import {
     ADDON_MOD_ASSIGN_COMPONENT,
     ADDON_MOD_ASSIGN_GRADED_EVENT,
     ADDON_MOD_ASSIGN_UNLIMITED_ATTEMPTS,
+    AddonModAssignAttemptReopenMethodValues,
+    AddonModAssignGradingStates,
 } from '../../constants';
 import { CoreCourse, CoreCourseModuleGradeInfo, CoreCourseModuleGradeOutcome } from '@features/course/services/course';
 import { AddonModAssignHelper, AddonModAssignSubmissionFormatted } from '../../services/assign-helper';

src/addons/mod/assign/components/feedback-plugin/feedback-plugin.ts

@@ -24,7 +24,7 @@ import {
 } from '../../services/assign';
 import { AddonModAssignHelper, AddonModAssignPluginConfig } from '../../services/assign-helper';
 import { AddonModAssignFeedbackDelegate } from '../../services/feedback-delegate';
-import { ADDON_MOD_ASSIGN_COMPONENT } from '../../constants';
+import { ADDON_MOD_ASSIGN_COMPONENT_LEGACY } from '../../constants';
 import { toBoolean } from '@/core/transforms/boolean';
 import { CoreSharedModule } from '@/core/shared.module';
 
@@ -54,7 +54,7 @@ export class AddonModAssignFeedbackPluginComponent implements OnInit {
     data?: AddonModAssignFeedbackPluginData; // Data to pass to the component.
 
     // Data to render the plugin if it isn't supported.
-    component = ADDON_MOD_ASSIGN_COMPONENT;
+    component = ADDON_MOD_ASSIGN_COMPONENT_LEGACY;
     text = '';
     files: CoreWSFile[] = [];
     notSupported = false;

src/addons/mod/assign/components/index/index.ts

@@ -27,7 +27,6 @@ import { CorePromiseUtils } from '@singletons/promise-utils';
 import { Translate } from '@singletons';
 import { CoreEventObserver, CoreEvents } from '@singletons/events';
 import { CoreTime } from '@singletons/time';
-import { AddonModAssignListFilterName } from '../../classes/submissions-source';
 import {
     AddonModAssign,
     AddonModAssignAssign,
@@ -42,15 +41,17 @@ import {
 import { AddonModAssignSubmissionComponent } from '../submission/submission';
 import {
     ADDON_MOD_ASSIGN_AUTO_SYNCED,
-    ADDON_MOD_ASSIGN_COMPONENT,
+    ADDON_MOD_ASSIGN_COMPONENT_LEGACY,
     ADDON_MOD_ASSIGN_GRADED_EVENT,
+    ADDON_MOD_ASSIGN_MODNAME,
     ADDON_MOD_ASSIGN_PAGE_NAME,
     ADDON_MOD_ASSIGN_STARTED_EVENT,
     ADDON_MOD_ASSIGN_SUBMISSION_REMOVED_EVENT,
     ADDON_MOD_ASSIGN_SUBMISSION_SAVED_EVENT,
     ADDON_MOD_ASSIGN_SUBMITTED_FOR_GRADING_EVENT,
     ADDON_MOD_ASSIGN_WARN_GROUPS_OPTIONAL,
     ADDON_MOD_ASSIGN_WARN_GROUPS_REQUIRED,
+    AddonModAssignListFilterName,
 } from '../../constants';
 import { CoreAlerts } from '@services/overlays/alerts';
 import { CoreSharedModule } from '@/core/shared.module';
@@ -75,8 +76,8 @@ export class AddonModAssignIndexComponent extends CoreCourseModuleMainActivityCo
 
     @ViewChild(AddonModAssignSubmissionComponent) submissionComponent?: AddonModAssignSubmissionComponent;
 
-    component = ADDON_MOD_ASSIGN_COMPONENT;
-    pluginName = 'assign';
+    component = ADDON_MOD_ASSIGN_COMPONENT_LEGACY;
+    pluginName = ADDON_MOD_ASSIGN_MODNAME;
 
     assign?: AddonModAssignAssign; // The assign object.
     canViewAllSubmissions = false; // Whether the user can view all submissions.

src/addons/mod/assign/components/submission-plugin/submission-plugin.ts

@@ -24,7 +24,7 @@ import { AddonModAssignHelper, AddonModAssignPluginConfig } from '../../services
 import { AddonModAssignSubmissionDelegate } from '../../services/submission-delegate';
 import { CoreFileEntry } from '@services/file-helper';
 import type { AddonModAssignSubmissionPluginBaseComponent } from '@addons/mod/assign/classes/base-submission-plugin-component';
-import { ADDON_MOD_ASSIGN_COMPONENT } from '../../constants';
+import { ADDON_MOD_ASSIGN_COMPONENT_LEGACY } from '../../constants';
 import { toBoolean } from '@/core/transforms/boolean';
 import { CoreSharedModule } from '@/core/shared.module';
 
@@ -53,7 +53,7 @@ export class AddonModAssignSubmissionPluginComponent implements OnChanges {
     data?: AddonModAssignSubmissionPluginData; // Data to pass to the component.
 
     // Data to render the plugin if it isn't supported.
-    component = ADDON_MOD_ASSIGN_COMPONENT;
+    component = ADDON_MOD_ASSIGN_COMPONENT_LEGACY;
     text = '';
     files: CoreFileEntry[] = [];
     notSupported = false;

src/addons/mod/assign/components/submission/submission.ts

@@ -23,9 +23,6 @@ import {
     AddonModAssignPlugin,
     AddonModAssign,
     AddonModAssignGetSubmissionStatusWSResponse,
-    AddonModAssignGradingStates,
-    AddonModAssignSubmissionStatusValues,
-    AddonModAssignAttemptReopenMethodValues,
     AddonModAssignGrade,
 } from '../../services/assign';
 import {
@@ -47,11 +44,15 @@ import { AddonModAssignSubmissionPluginComponent } from '../submission-plugin/su
 import { CoreTime } from '@singletons/time';
 import { CoreIonicColorNames } from '@singletons/colors';
 import {
-    ADDON_MOD_ASSIGN_COMPONENT,
+    ADDON_MOD_ASSIGN_COMPONENT_LEGACY,
     ADDON_MOD_ASSIGN_MANUAL_SYNCED,
+    ADDON_MOD_ASSIGN_MODNAME,
     ADDON_MOD_ASSIGN_PAGE_NAME,
     ADDON_MOD_ASSIGN_SUBMISSION_REMOVED_EVENT,
     ADDON_MOD_ASSIGN_SUBMITTED_FOR_GRADING_EVENT,
+    AddonModAssignAttemptReopenMethodValues,
+    AddonModAssignGradingStates,
+    AddonModAssignSubmissionStatusValues,
 } from '../../constants';
 import { CoreViewer } from '@features/viewer/services/viewer';
 import { CoreLoadings } from '@services/overlays/loadings';
@@ -353,7 +354,7 @@ export class AddonModAssignSubmissionComponent implements OnInit {
             const sent = await AddonModAssign.removeSubmission(this.assign, this.userSubmission);
 
             if (sent) {
-                CoreEvents.trigger(CoreEvents.ACTIVITY_DATA_SENT, { module: 'assign' });
+                CoreEvents.trigger(CoreEvents.ACTIVITY_DATA_SENT, { module: ADDON_MOD_ASSIGN_MODNAME });
             }
 
             CoreEvents.trigger(
@@ -751,7 +752,7 @@ export class AddonModAssignSubmissionComponent implements OnInit {
             Translate.instant('core.grades.grade'),
             grade,
             {
-                component: ADDON_MOD_ASSIGN_COMPONENT,
+                component: ADDON_MOD_ASSIGN_COMPONENT_LEGACY,
                 componentId: this.moduleId,
             },
         );

src/addons/mod/assign/constants.ts

@@ -14,8 +14,15 @@
 
 export const ADDON_MOD_ASSIGN_FEATURE_NAME = 'CoreCourseModuleDelegate_AddonModAssign';
 
-export const ADDON_MOD_ASSIGN_COMPONENT = 'mmaModAssign';
+export const ADDON_MOD_ASSIGN_COMPONENT_LEGACY = 'mmaModAssign';
+export const ADDON_MOD_ASSIGN_COMPONENT = 'AddonModAssign';
+
 export const ADDON_MOD_ASSIGN_PAGE_NAME = 'mod_assign';
+export const ADDON_MOD_ASSIGN_MODNAME = 'assign';
+
+export const ADDON_MOD_ASSIGN_PREFETCH_NAME = ADDON_MOD_ASSIGN_COMPONENT;
+
+export const ADDON_MOD_ASSIGN_SYNC_CRON_NAME = 'AddonModAssignSyncCronHandler';
 
 export const ADDON_MOD_ASSIGN_UNLIMITED_ATTEMPTS = -1;
 
@@ -31,3 +38,51 @@ export const ADDON_MOD_ASSIGN_GRADED_EVENT = 'addon_mod_assign_graded';
 export const ADDON_MOD_ASSIGN_STARTED_EVENT = 'addon_mod_assign_started';
 export const ADDON_MOD_ASSIGN_AUTO_SYNCED = 'addon_mod_assign_autom_synced';
 export const ADDON_MOD_ASSIGN_MANUAL_SYNCED = 'addon_mod_assign_manual_synced';
+
+/**
+ * Submission status.
+ * Constants on LMS starting with ASSIGN_SUBMISSION_STATUS_
+ */
+export const enum AddonModAssignSubmissionStatusValues {
+    SUBMITTED = 'submitted',
+    DRAFT = 'draft',
+    NEW = 'new',
+    REOPENED = 'reopened',
+    // Added by App Statuses.
+    NO_ATTEMPT = 'noattempt',
+    NO_ONLINE_SUBMISSIONS = 'noonlinesubmissions',
+    NO_SUBMISSION = 'nosubmission',
+    GRADED_FOLLOWUP_SUBMIT = 'gradedfollowupsubmit',
+}
+
+/**
+ * Grading status.
+ * Constants on LMS starting with ASSIGN_GRADING_STATUS_
+ */
+export const enum AddonModAssignGradingStates {
+    GRADED = 'graded',
+    NOT_GRADED = 'notgraded',
+    // Added by App Statuses.
+    MARKING_WORKFLOW_STATE_RELEASED = 'released', // with ASSIGN_MARKING_WORKFLOW_STATE_RELEASED
+    GRADED_FOLLOWUP_SUBMIT = 'gradedfollowupsubmit',
+}
+
+/**
+ * Reopen attempt methods.
+ * Constants on LMS starting with ASSIGN_ATTEMPT_REOPEN_METHOD_
+ */
+export const enum AddonModAssignAttemptReopenMethodValues {
+    NONE = 'none',
+    MANUAL = 'manual',
+    UNTILPASS = 'untilpass',
+}
+
+/**
+ * List filter by status name.
+ */
+export const enum AddonModAssignListFilterName {
+    ALL = '',
+    NEED_GRADING = 'needgrading',
+    DRAFT = 'draft',
+    SUBMITTED = 'submitted',
+}

src/addons/mod/assign/feedback/comments/component/comments.ts

@@ -26,7 +26,7 @@ import { AddonModAssignOffline } from '@addons/mod/assign/services/assign-offlin
 import { CorePromiseUtils } from '@singletons/promise-utils';
 import { AddonModAssignFeedbackPluginBaseComponent } from '@addons/mod/assign/classes/base-feedback-plugin-component';
 import { ContextLevel } from '@/core/constants';
-import { ADDON_MOD_ASSIGN_COMPONENT } from '@addons/mod/assign/constants';
+import { ADDON_MOD_ASSIGN_COMPONENT_LEGACY } from '@addons/mod/assign/constants';
 import { CoreViewer } from '@features/viewer/services/viewer';
 import { CoreEditorRichTextEditorComponent } from '@features/editor/components/rich-text-editor/rich-text-editor';
 import { CoreSharedModule } from '@/core/shared.module';
@@ -46,7 +46,7 @@ import { CoreSharedModule } from '@/core/shared.module';
 export class AddonModAssignFeedbackCommentsComponent extends AddonModAssignFeedbackPluginBaseComponent implements OnInit {
 
     control?: FormControl<string>;
-    component = ADDON_MOD_ASSIGN_COMPONENT;
+    component = ADDON_MOD_ASSIGN_COMPONENT_LEGACY;
     text = '';
     isSent = false;
     loaded = false;

src/addons/mod/assign/feedback/editpdf/component/editpdf.ts

@@ -13,7 +13,7 @@
 // limitations under the License.
 
 import { AddonModAssignFeedbackPluginBaseComponent } from '@addons/mod/assign/classes/base-feedback-plugin-component';
-import { ADDON_MOD_ASSIGN_COMPONENT } from '@addons/mod/assign/constants';
+import { ADDON_MOD_ASSIGN_COMPONENT_LEGACY } from '@addons/mod/assign/constants';
 import { AddonModAssign } from '@addons/mod/assign/services/assign';
 import { Component, OnInit } from '@angular/core';
 import { CoreWSFile } from '@services/ws';
@@ -32,7 +32,7 @@ import { CoreSharedModule } from '@/core/shared.module';
 })
 export class AddonModAssignFeedbackEditPdfComponent extends AddonModAssignFeedbackPluginBaseComponent implements OnInit {
 
-    component = ADDON_MOD_ASSIGN_COMPONENT;
+    component = ADDON_MOD_ASSIGN_COMPONENT_LEGACY;
     files: CoreWSFile[] = [];
 
     /**