Skip to content

Commit 666caca

Browse files
authored
Merge pull request #4200 from dpalou/MOBILE-4616
Mobile 4616
2 parents 0fdb03a + 5d3c637 commit 666caca

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

src/addons/badges/pages/badge-class/badge-class.html

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,9 @@ <h1 *ngIf="!badge">{{ 'addon.badges.badgedetails' | translate }}</h1>
3030
<ion-item class="ion-text-wrap" *ngIf="badge.issuer">
3131
<ion-label>
3232
<p class="item-heading">{{ 'addon.badges.issuername' | translate}}</p>
33-
<p>{{ badge.issuer }}</p>
33+
<p>
34+
<core-format-text [text]="badge.issuer" contextLevel="system" [contextInstanceId]="0" [wsNotFiltered]="true" />
35+
</p>
3436
</ion-label>
3537
</ion-item>
3638
<ion-item class="ion-text-wrap" *ngIf="badge.coursefullname">

src/core/features/reportbuilder/components/report-detail/report-detail.ts

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
// limitations under the License.
1414

1515
import { toBoolean } from '@/core/transforms/boolean';
16-
import { ChangeDetectionStrategy, Component, EventEmitter, Input, OnInit, Output } from '@angular/core';
16+
import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core';
1717
import { CoreError } from '@classes/errors/error';
1818
import {
1919
CoreReportBuilder,
@@ -37,7 +37,6 @@ import { map } from 'rxjs/operators';
3737
selector: 'core-report-builder-report-detail',
3838
templateUrl: './report-detail.html',
3939
styleUrls: ['./report-detail.scss'],
40-
changeDetection: ChangeDetectionStrategy.OnPush,
4140
})
4241
export class CoreReportBuilderReportDetailComponent implements OnInit {
4342

@@ -55,7 +54,7 @@ export class CoreReportBuilderReportDetailComponent implements OnInit {
5554
new BehaviorSubject<CoreReportBuilderReportDetailState>({
5655
report: null,
5756
loaded: false,
58-
canLoadMoreRows: true,
57+
canLoadMoreRows: false,
5958
errorLoadingRows: false,
6059
cardviewShowFirstTitle: false,
6160
cardVisibleColumns: 1,
@@ -126,6 +125,7 @@ export class CoreReportBuilderReportDetailComponent implements OnInit {
126125
report,
127126
cardVisibleColumns: report.details.settingsdata.cardviewVisibleColumns,
128127
cardviewShowFirstTitle: report.details.settingsdata.cardviewShowFirstTitle,
128+
canLoadMoreRows: report.data.totalrowcount > report.data.rows.length,
129129
});
130130

131131
this.logView(report);
@@ -175,7 +175,6 @@ export class CoreReportBuilderReportDetailComponent implements OnInit {
175175
this.updateState({ page: 0, canLoadMoreRows: false });
176176
await CoreUtils.ignoreErrors(this.getReport());
177177
await ionRefresher?.complete();
178-
this.updateState({ canLoadMoreRows: true });
179178
}
180179

181180
/**
@@ -225,12 +224,12 @@ export class CoreReportBuilderReportDetailComponent implements OnInit {
225224
],
226225
},
227226
},
227+
canLoadMoreRows: newReport.data.totalrowcount > report.data.rows.length + newReport.data.rows.length,
228228
});
229229
} catch (error) {
230230
CoreDomUtils.showErrorModalDefault(error, 'Error loading more reports');
231231

232-
this.updateState({ canLoadMoreRows: false });
233-
this.updateState({ errorLoadingRows: true });
232+
this.updateState({ canLoadMoreRows: false, errorLoadingRows: true });
234233
}
235234

236235
complete();

0 commit comments

Comments
 (0)