Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we remove waldo dependency but still use it if it's there ? #7

Open
moodymudskipper opened this issue Oct 20, 2020 · 6 comments
Open
Milestone

Comments

@moodymudskipper
Copy link
Owner

It's nice for a package like {typed} to be dependy free, {waldo} has many dependencies itself, though all quite small I think.

{waldo} plays really well with this package though, so I want to use it. But we can use if(requireNamespace("waldo")) and move it to "Suggests" if we provide alternate errors.

Let's have something stable first though.

@vikram-rawat
Copy link
Contributor

Everything that you are doing to create types can all be done through Rcpp quite efficiently without any imports

@moodymudskipper
Copy link
Owner Author

In the absolute sense I guess, though Rcpp will be the dependency then. But you'd have to reprogram {crayon} and {waldo} basically. Waldo in particular is quite amazing and does more than what my examples in Readme show.

@nathaneastwood
Copy link

You could maybe just go with {diffobj} by @brodieG: https://github.com/brodieG/diffobj

@moodymudskipper
Copy link
Owner Author

That's a good idea! {diffobj} depends only on {crayon}, which has no dependency. I think it will be a good compromise.

@brodieG
Copy link

brodieG commented Nov 4, 2020

Just an fyi, I have a long term plan to change the crayon dependency to fansi, which has no dependencies and will remain with no dependencies. I also generally try to keep dependencies at a minimum.

Aside, waldo currently imports diffobj, FWIW.

@moodymudskipper
Copy link
Owner Author

Thanks Brodie!

@moodymudskipper moodymudskipper added this to the backlog milestone Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants