Skip to content

op_shl and op_shr API is unsafe in native backend #1607

Closed
@illusory0x0

Description

@illusory0x0

https://en.cppreference.com/w/c/language/operator_arithmetic

The behavior is undefined if rhs is negative or is greater or equal the number of bits in the promoted lhs.

///|
pub fn Int::op_shl(self : Int, other : Int) -> Int = "%i32_shl"

///|
pub fn Int::op_shr(self : Int, other : Int) -> Int = "%i32_shr"

I recommend the following API

///|
pub fn Int::op_shl(self : Int, other : UInt) -> Int

///|
pub fn Int::op_shr(self : Int, other : UInt) -> Int

and if greater or equal the number of bits in the promoted lhs, I think we need to panic in all backend.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions