Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to add custom token to stream #22

Open
codenamejason opened this issue Jan 18, 2022 · 7 comments
Open

Ability to add custom token to stream #22

codenamejason opened this issue Jan 18, 2022 · 7 comments
Labels
enhancement New feature or request stream approved

Comments

@codenamejason
Copy link
Collaborator

No description provided.

@codenamejason codenamejason added enhancement New feature or request good first issue Good for newcomers labels Jan 18, 2022
@moiz-lakkadkutta
Copy link
Contributor

moiz-lakkadkutta commented Feb 11, 2022 •
edited
Loading

@codenamejason can elaborate on this issue?
Right now 3 tokens GTC DAI UNI has to be added?
Or user can add their custom token with address?

@codenamejason
Copy link
Collaborator Author

We want to allow a user to add a token by entering a contract address. Check out this component here.

@moiz-lakkadkutta
Copy link
Contributor

Great I would like to work on it.

@moiz-lakkadkutta
Copy link
Contributor

moiz-lakkadkutta commented Feb 12, 2022 •
edited
Loading

@codenamejason do we have to set a minimum value to start the stream as different tokens have different values?
say 10 USD

moiz-lakkadkutta added a commit to moiz-lakkadkutta/tokenstream.party that referenced this issue Feb 12, 2022
@moiz-lakkadkutta
User can add custom ERC20 token for the stream.
3bf29ba 
closes issue moonshotcollective#22
@moiz-lakkadkutta moiz-lakkadkutta mentioned this issue Feb 12, 2022
Closed
@moiz-lakkadkutta
Copy link
Contributor

@codenamejason ?

@codenamejason
Copy link
Collaborator Author

@moiz-lakkadkutta sorry for delay, was at ETH Denver.

That is a good question. Let's hold off on this until I get more info from product.

@codenamejason codenamejason removed the good first issue Good for newcomers label Mar 8, 2022
@moiz-lakkadkutta
Copy link
Contributor

@codenamejason any updates?

supriyaamisshra added a commit to supriyaamisshra/tokenstream.party that referenced this issue Apr 10, 2022
@supriyaamisshra
- Added support for custom tokens. Closes moonshotcollective#22
d42ba6e
@supriyaamisshra supriyaamisshra mentioned this issue Apr 10, 2022
Merged
@codenamejason codenamejason reopened this Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request stream approved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codenamejason @moiz-lakkadkutta