From 65caba29b7be487d85a630440d6e3fae8bd4874a Mon Sep 17 00:00:00 2001 From: Eric Harding Date: Thu, 13 Apr 2023 11:30:52 -0400 Subject: [PATCH 1/3] String may be the first string in a section --- include/binlog/detail/read_sources_linux.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/binlog/detail/read_sources_linux.hpp b/include/binlog/detail/read_sources_linux.hpp index 396eb4e..dd978e1 100644 --- a/include/binlog/detail/read_sources_linux.hpp +++ b/include/binlog/detail/read_sources_linux.hpp @@ -42,7 +42,7 @@ inline void add_event_sources_of_file(const std::string& path, std::uintptr_t lo { for (const ElfW(Shdr)& shdr : shdrs) { - if (shdr.sh_addr < v && shdr.sh_addr + shdr.sh_size > v) + if (shdr.sh_addr <= v && shdr.sh_addr + shdr.sh_size > v) { return v - shdr.sh_addr + shdr.sh_offset; } From 4e81d7da670f03405c18726b6ca1a0cd8f78244d Mon Sep 17 00:00:00 2001 From: Eric Harding Date: Fri, 14 Apr 2023 09:20:55 -0400 Subject: [PATCH 2/3] Update clang-tidy install command to match master branch --- .github/workflows/on_pull_request.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/on_pull_request.yml b/.github/workflows/on_pull_request.yml index d072f56..d89915f 100644 --- a/.github/workflows/on_pull_request.yml +++ b/.github/workflows/on_pull_request.yml @@ -106,9 +106,7 @@ jobs: - uses: actions/checkout@v2 - name: Install Dependencies run: | - # remove broken packages installed by default - sudo apt remove -y clang-6.0 libclang-common-6.0-dev libclang1-6.0 libllvm6.0 - sudo apt install -y clang clang-tidy + sudo apt install -y clang clang-tidy ldd - name: Configure run: | set -x From f01f66f474f7232b9d367876e0ae0c2ca1ddc54d Mon Sep 17 00:00:00 2001 From: Eric Harding Date: Fri, 14 Apr 2023 09:28:10 -0400 Subject: [PATCH 3/3] lld, not ldd --- .github/workflows/on_pull_request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/on_pull_request.yml b/.github/workflows/on_pull_request.yml index d89915f..f26b176 100644 --- a/.github/workflows/on_pull_request.yml +++ b/.github/workflows/on_pull_request.yml @@ -106,7 +106,7 @@ jobs: - uses: actions/checkout@v2 - name: Install Dependencies run: | - sudo apt install -y clang clang-tidy ldd + sudo apt install -y clang clang-tidy lld - name: Configure run: | set -x