Fix virtual properties in get_class_vars() (phpGH-15494)

Fixes phpGH-15456

Author: iluuu1994

NEWS

@@ -10,6 +10,8 @@ PHP                                                                        NEWS
   . Fixed bug GH-15419 (Missing readonly+hook incompatibility check for readonly
     classes). (ilutov)
   . Fixed bug GH-15187 (Various hooked object iterator issues). (ilutov)
+  . Fixed bug GH-15456 (Crash in get_class_vars() on virtual properties).
+    (ilutov)
 
 15 Aug 2024, PHP 8.4.0beta3
 

Zend/tests/property_hooks/gh15456.phpt

@@ -0,0 +1,20 @@
+--TEST--
+GH-15456: Crash in get_class_vars() on virtual properties
+--FILE--
+<?php
+
+class C {
+    public $a = 42;
+    public $b = 42 { get => $this->b * 2; }
+    public $c { get => 42; }
+}
+var_dump(get_class_vars(C::class));
+
+?>
+--EXPECT--
+array(2) {
+  ["a"]=>
+  int(42)
+  ["b"]=>
+  int(42)
+}

Zend/zend_builtin_functions.c

@@ -724,7 +724,8 @@ static void add_class_vars(zend_class_entry *scope, zend_class_entry *ce, bool s
 		if (((prop_info->flags & ZEND_ACC_PROTECTED) &&
 			 !zend_check_protected(prop_info->ce, scope)) ||
 			((prop_info->flags & ZEND_ACC_PRIVATE) &&
-			  prop_info->ce != scope)) {
+			  prop_info->ce != scope) ||
+			(prop_info->flags & ZEND_ACC_VIRTUAL)) {
 			continue;
 		}
 		prop = NULL;