-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ownership mine filter #3
base: main
Are you sure you want to change the base?
Conversation
Thanks for submitting. I'll review this in a day or two. In the meantime, do you have some sample data I can test this with? |
Sure, here's a sample:
|
@@ -111,17 +111,28 @@ def main(): | |||
type=str, | |||
help="File name used for outputted csv. Should include .csv extension" | |||
) | |||
parser.add_argument( | |||
'-m', | |||
'--mine', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are your thoughts on making this argument --ownership
?
I am thinking that then a user can pass nargs of strings (MINE
, NOT_MINE
, UNKNOWN
) and the script will include any matching trips
if the Ownership matches.
Hey @downey-lv, just wanted to see if you were planning to make the suggested changes? |
Sorry about the delay, I agree with your suggestion, will push an update |
I had quite a few flights that I had booked for others and sorted so in AITA, added flag to exclude those here.
Possible values for the ownership is Ownership.MINE, Ownership.NOT_MINE, Ownership.UNKNOWN
I'm seeing the UNKNOWN one for hotel only entries.