Skip to content

Commit a937acc

Browse files
committed
fix reviewer comments
1 parent 9fe7756 commit a937acc

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

.github/workflows/staging-push.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,10 @@ jobs:
5050
#- name: Update DB - test runs
5151
# run: python ./__main__.py --report-type test-run-counts --project fenix --start-date 2021-08-15 --end-date 2021-10-01
5252

53-
- name: Jira query
53+
- name: Jira query qa-requests
5454
run: python ./__main__.py --report-type jira-qa-requests
55-
- name: Jira query
55+
- name: Jira query qa-needed
56+
if: always()
5657
run: python ./__main__.py --report-type jira-qa-needed
5758
- name: Set job log URL
5859
if: always()

jira.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ def jira_qa_needed(self):
7272
data_frame = self.db.report_jira_qa_needed(payload)
7373
print(data_frame)
7474

75-
self.db.report_jira_qa_needed_instert(data_frame)
75+
self.db.report_jira_qa_needed_insert(data_frame)
7676

7777

7878
class DatabaseJira(Database):
@@ -156,15 +156,15 @@ def report_jira_qa_needed(self, payload):
156156

157157
# Join list of labels into a single string
158158
jira_labels = df['fields_labels'] = df['fields_labels'].apply(lambda x: ','.join(x) if isinstance(x, list) else x) # noqa
159-
# Calcule the Nightly Verified label
159+
# Calculate Nightly Verified label
160160
verified_nightly_count = jira_labels.str.contains('verified', case=False, na=False).sum() # noqa
161161

162162
not_verified_count = total_rows - verified_nightly_count
163163

164164
data = [total_rows, not_verified_count, verified_nightly_count]
165165
return data
166166

167-
def report_jira_qa_needed_instert(self, payload):
167+
def report_jira_qa_needed_insert(self, payload):
168168
report = ReportJiraQANeeded(jira_total_qa_needed=payload[0],
169169
jira_qa_needed_not_verified=payload[1],
170170
jira_qa_needed_verified_nightly=payload[2])

0 commit comments

Comments
 (0)