Experiment approval/rejection process UI #12072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

data-sync-user opened this issue Jan 20, 2025 · 0 comments · Fixed by #12090

Assignees

Collaborator

data-sync-user commented Jan 20, 2025

┆Issue is synchronized with this Jira Task

data-sync-user assigned yashikakhurana

yashikakhurana mentioned this issue

feat(nimbus): Approval and rejection flow #12090

Merged

github-merge-queue bot pushed a commit that referenced this issue


          feat(nimbus): Approval and rejection flow (#12090)

d9ad3f9

Because

- We want to add approval and rejection flow on the new summary page

This commit

- Add option to approve and Launch
- Add the option to reject the experiment with the message
- Shows the timeout message 

Fixes #12072 
Note: This currently does not show the rejection reason-which I will add
in the separate PR

Approval flow



https://github.com/user-attachments/assets/84731825-e241-43fd-b9d0-f9dc2922c85c


Rejection flow



https://github.com/user-attachments/assets/9d201e88-cfc7-49f3-b6ba-3fd110488237


Timeout message
<img width="1687" alt="Screenshot 2025-01-22 at 10 27 54 AM"
src="https://github.com/user-attachments/assets/b2d07515-15d2-40d5-882e-edbf67032cda"
/>

---------

Co-authored-by: Jared Lockhart <[email protected]>

yashikakhurana closed this as completed in #12090

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment