disable busted suggestion test; wait for elements in passman

ben-c-at-moz · ben-c-at-moz · commit 933de8161ed8 · 2025-06-18T09:16:46.000-06:00
diff --git a/tests/address_bar_and_search/test_search_suggestions.py b/tests/address_bar_and_search/test_search_suggestions.py
@@ -19,6 +19,8 @@ def test_case():
     return "3029158"
 
 
+# Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1972726
+@pytest.mark.unstable
 def test_search_suggests_enabled(driver: Firefox):
     """
     C1618400: Firefox Suggest displays sponsored and non-sponsored suggestions when enabled in Preferences
diff --git a/tests/password_manager/test_changes_made_in_edit_mode_are_saved.py b/tests/password_manager/test_changes_made_in_edit_mode_are_saved.py
@@ -34,6 +34,7 @@ def test_changes_made_in_edit_mode_are_saved(driver: Firefox):
         }
     )
     # Click the "Edit" button
+    about_logins.element_visible("edit-login")
     about_logins.click_on("edit-login")
 
     # Change username and the password
diff --git a/tests/password_manager/test_saved_hyperlink_redirects_to_corresponding_page.py b/tests/password_manager/test_saved_hyperlink_redirects_to_corresponding_page.py
@@ -40,6 +40,7 @@ def test_saved_hyperlink_redirects_to_corresponding_page(driver: Firefox):
     )
 
     # Click on the hyperlink website
+    about_logins.element_visible("website-address")
     about_logins.click_on("website-address")
     about_logins.switch_to_new_tab()
     about_logins.url_contains("mozilla.github")

Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,7 @@ def test_changes_made_in_edit_mode_are_saved(driver: Firefox):`
`34`	`34`	`}`
`35`	`35`	`)`
`36`	`36`	`# Click the "Edit" button`
	`37`	`+ about_logins.element_visible("edit-login")`
`37`	`38`	`about_logins.click_on("edit-login")`
`38`	`39`
`39`	`40`	`# Change username and the password`
Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,7 @@ def test_saved_hyperlink_redirects_to_corresponding_page(driver: Firefox):`
`40`	`40`	`)`
`41`	`41`
`42`	`42`	`# Click on the hyperlink website`
	`43`	`+ about_logins.element_visible("website-address")`
`43`	`44`	`about_logins.click_on("website-address")`
`44`	`45`	`about_logins.switch_to_new_tab()`
`45`	`46`	`about_logins.url_contains("mozilla.github")`