Skip to content

Commit acec709

Browse files
authored
Refactor issue field update logic to handle None values (#1271)
1 parent d01ecc8 commit acec709

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

jbi/jira/service.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,9 @@ def update_issue_field(
287287
bug.id,
288288
extra=context.model_dump(),
289289
)
290-
fields: dict[str, Any] = {field: {wrap_value: value} if wrap_value else value}
290+
fields: dict[str, Any] = {
291+
field: {wrap_value: value} if wrap_value and value is not None else value
292+
}
291293
response = self.client.update_issue_field(key=issue_key, fields=fields)
292294
logger.info(
293295
f"Updated {field} of Jira issue %s to %s for Bug %s",

tests/unit/test_steps.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1018,7 +1018,7 @@ def test_update_issue_severity_clear_when_none(
10181018

10191019
mocked_jira.create_issue.assert_not_called()
10201020
mocked_jira.update_issue_field.assert_called_with(
1021-
key="JBI-234", fields={"customfield_10319": {"value": None}}
1021+
key="JBI-234", fields={"customfield_10319": None}
10221022
)
10231023

10241024

0 commit comments

Comments
 (0)