Skip to content

Commit c57f9cf

Browse files
committed
Adjust severity field according to mozilla-hub
1 parent 724a0b2 commit c57f9cf

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

jbi/models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ class ActionParams(BaseModel, frozen=True):
7474
jira_project_key: str
7575
steps: ActionSteps = ActionSteps()
7676
jira_components: JiraComponents = JiraComponents()
77-
jira_severity_field: str = "severity"
77+
jira_severity_field: str = "customfield_10716"
7878
jira_priority_field: str = "priority"
7979
jira_resolution_field: str = "resolution"
8080
labels_brackets: Literal["yes", "no", "both"] = "no"

jbi/steps.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ def _maybe_update_issue_mapped_field(
209209
) -> StepResult:
210210
source_value = getattr(context.bug, source_field, None) or ""
211211
target_field = getattr(parameters, f"jira_{source_field}_field")
212-
target_value = getattr(parameters, f"{target_field}_map").get(source_value)
212+
target_value = getattr(parameters, f"{source_field}_map").get(source_value)
213213
if target_value is None:
214214
logger.info(
215215
f"Bug {source_field} %r was not in the {source_field} map.",
@@ -274,7 +274,7 @@ def maybe_update_issue_severity(
274274
Update the Jira issue severity
275275
"""
276276
return _maybe_update_issue_mapped_field(
277-
"severity", context, parameters, jira_service, wrap_value="name"
277+
"severity", context, parameters, jira_service, wrap_value="value"
278278
)
279279

280280

tests/unit/test_steps.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -757,7 +757,7 @@ def test_update_issue_priority(
757757
)
758758

759759
mocked_jira.create_issue.assert_not_called()
760-
mocked_jira.update_issue_field(
760+
mocked_jira.update_issue_field.assert_called_with(
761761
key="JBI-234", fields={"priority": {"name": "Urgent"}}
762762
)
763763

@@ -782,7 +782,7 @@ def test_update_issue_severity(
782782

783783
params = action_params_factory(
784784
jira_project_key=action_context.jira.project,
785-
status_map={
785+
severity_map={
786786
"S3": "Moderate",
787787
},
788788
)
@@ -791,8 +791,8 @@ def test_update_issue_severity(
791791
)
792792

793793
mocked_jira.create_issue.assert_not_called()
794-
mocked_jira.update_issue_field(
795-
key="JBI-234", fields={"severity": {"name": "Moderate"}}
794+
mocked_jira.update_issue_field.assert_called_with(
795+
key="JBI-234", fields={"customfield_10716": {"value": "Moderate"}}
796796
)
797797

798798

0 commit comments

Comments
 (0)