Fix ActionDispatch::Request::HTTP_METHOD_LOOKUP being impacted by inflections from gems

obrie · mrpasquini · commit 5f1b41dc0010 · 2025-01-23T15:00:04.000-08:00
If a gem adds inflections before action_dispatch/http/request is loaded into the runtime,
then it's possible that calls to method#underscore cause invalid values to be generated.

For example, if a gem adds "OS" as an acronym, then this will cause "POST" to be converted
to :p_os_t.
diff --git a/actionpack/lib/action_dispatch/http/request.rb b/actionpack/lib/action_dispatch/http/request.rb
@@ -138,7 +138,7 @@ def key?(key)
 
     # Populate the HTTP method lookup cache.
     HTTP_METHODS.each { |method|
-      HTTP_METHOD_LOOKUP[method] = method.underscore.to_sym
+      HTTP_METHOD_LOOKUP[method] = method.downcase.underscore.to_sym
     }
 
     alias raw_request_method request_method # :nodoc:

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ def key?(key)`
`138`	`138`
`139`	`139`	`# Populate the HTTP method lookup cache.`
`140`	`140`	`HTTP_METHODS.each { \|method\|`
`141`		`- HTTP_METHOD_LOOKUP[method] = method.underscore.to_sym`
	`141`	`+ HTTP_METHOD_LOOKUP[method] = method.downcase.underscore.to_sym`
`142`	`142`	`}`
`143`	`143`
`144`	`144`	`alias raw_request_method request_method # :nodoc:`