fix(vendor): Remove excessive URL validation

mss · mss · commit 7b0c6735a514 · 2025-02-05T13:20:02.000+01:00
Fixes cloudposse#1019
diff --git a/internal/exec/go_getter_utils.go b/internal/exec/go_getter_utils.go
@@ -27,18 +27,13 @@ func ValidateURI(uri string) error {
 	if len(uri) > 2048 {
 		return fmt.Errorf("URI exceeds maximum length of 2048 characters")
 	}
-	// Add more validation as needed
 	// Validate URI format
 	if strings.Contains(uri, "..") {
 		return fmt.Errorf("URI cannot contain path traversal sequences")
 	}
 	if strings.Contains(uri, " ") {
 		return fmt.Errorf("URI cannot contain spaces")
 	}
-	// Validate characters
-	if strings.ContainsAny(uri, "<>|&;$") {
-		return fmt.Errorf("URI contains invalid characters")
-	}
 	// Validate scheme-specific format
 	if strings.HasPrefix(uri, "oci://") {
 		if !strings.Contains(uri[6:], "/") {

Original file line number	Diff line number	Diff line change
`@@ -27,18 +27,13 @@ func ValidateURI(uri string) error {`
`27`	`27`	`if len(uri) > 2048 {`
`28`	`28`	`return fmt.Errorf("URI exceeds maximum length of 2048 characters")`
`29`	`29`	`}`
`30`		`- // Add more validation as needed`
`31`	`30`	`// Validate URI format`
`32`	`31`	`if strings.Contains(uri, "..") {`
`33`	`32`	`return fmt.Errorf("URI cannot contain path traversal sequences")`
`34`	`33`	`}`
`35`	`34`	`if strings.Contains(uri, " ") {`
`36`	`35`	`return fmt.Errorf("URI cannot contain spaces")`
`37`	`36`	`}`
`38`		`- // Validate characters`
`39`		`- if strings.ContainsAny(uri, "<>\|&;$") {`
`40`		`- return fmt.Errorf("URI contains invalid characters")`
`41`		`- }`
`42`	`37`	`// Validate scheme-specific format`
`43`	`38`	`if strings.HasPrefix(uri, "oci://") {`
`44`	`39`	`if !strings.Contains(uri[6:], "/") {`