Skip to content

Commit 021af31

Browse files
committed
run-lldb-tests: Skip the separate strip step when using PDB files
Since 7dcd8ef135147de1576c2863b963ec929a15e8cb in llvm-project (Dec 15th), LLD can strip out the bundled DWARF debug info directly when linking, while creating a PDB file, simplifying this test case.
1 parent 1d276f5 commit 021af31

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

run-lldb-tests.sh

+2-7
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ export PATH=$PREFIX/bin:$PATH
2828
# in msys2 bash and in bash in WSL.
2929
: ${CXX:=clang++.exe}
3030
: ${LLDB:=lldb.exe}
31-
: ${STRIP:=strip.exe}
3231
: ${OBJCOPY:=objcopy.exe}
3332

3433
TARGET=$(clang.exe --version | grep Target: | awk '{print $2}')
@@ -44,12 +43,8 @@ mkdir -p $TEST_DIR
4443
# Build an executable with DWARF debug info
4544
$CXX hello-exception.cpp -o $TEST_DIR/hello-exception-dwarf.exe -g
4645

47-
# Build an executable with PDB debug info
48-
$CXX hello-exception.cpp -o $TEST_DIR/hello-exception-pdb.exe -g -gcodeview -Wl,--pdb=
49-
# Strip the executable that uses pdb; the crt startup files and mingw static
50-
# library object files have dwarf debug info, so the binary has got a bit of
51-
# both, and lldb would choose to use the dwarf parts unless we strip it.
52-
$STRIP $TEST_DIR/hello-exception-pdb.exe
46+
# Build an executable with PDB debug info. Strip out any bundled DWARF debug info.
47+
$CXX hello-exception.cpp -o $TEST_DIR/hello-exception-pdb.exe -g -gcodeview -Wl,--pdb= -Wl,-s
5348

5449
# Make a DWARF split debug info file with gnu debuglink.
5550
cp $TEST_DIR/hello-exception-dwarf.exe $TEST_DIR/hello-exception-split.exe

0 commit comments

Comments
 (0)