Skip to content
This repository was archived by the owner on Jan 9, 2025. It is now read-only.

CreateAndWaitForReadiness has no field validation #12

Open
garrettthomaskth opened this issue Oct 18, 2022 · 2 comments
Open

CreateAndWaitForReadiness has no field validation #12

garrettthomaskth opened this issue Oct 18, 2022 · 2 comments

Comments

@garrettthomaskth
Copy link

In the CreateAndWaitForReadiness function, create is called without any option set for FieldValidation, which defaults to Ignore. We should either set set the FieldValidation to at least "Warn" (I would prefer "Strict", unless anyone knows any downsides to this) or enable the ServerSideFieldValidation feature gate.

@thetechnick
Copy link
Contributor

Can you pleas link to the function in question?
Validation during AdmissionControl is non-optional on the server-side, so I am not sure what client setting you are referring to.

@garrettthomaskth
Copy link
Author

Oh sorry. I am talking about the controller-runtime's client's Create function here https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/client/client.go#L181 and this field in the create options https://github.com/kubernetes/apimachinery/blob/master/pkg/apis/meta/v1/types.go#L563

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants