Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to get ie9 to work with path.js. #59

Open
jwbworks opened this issue Apr 16, 2013 · 4 comments
Open

unable to get ie9 to work with path.js. #59

jwbworks opened this issue Apr 16, 2013 · 4 comments

Comments

@jwbworks
Copy link

Hello,

see there were past issues with ie9 that are now closed. However I am trying to load the demo pages (http://mtrpcic.github.io/pathjs/) in ie9 and clicking on the left nav and nothing happens. When I try the to run it in ieTester and try ie9 , 8 and even ie7, I get errors on line 180 char 21. Object expected.

Can someone confirm that IE is still supported? If so is there something special that needs to be done to get it to work?

-ps- I have a POc that I am building the paths work great in ff, chrome and safari its only IE not working. in IE when the user clicks on a button to go from the login page I reroutre through a success path, then to the workspace path. in all browser it works. in ie the log in button just loops back on to it self.

here is my path code

Path.map("#/login").to(function(){
brite.display("Login","#pageBody");
});

Path.map("#/success").to(function(){
//simulate time to login

loggedIn = true;
$('#pageBody').empty();
location.hash = '#/workspace';

});

Path.map("#/error").to(function(){
alert("A Login Error has Occured!");
});

Path.map("#/workspace").to(function(){
checkAuth();
brite.display("MainView","#pageBody");
});

Path.map("#/bulk001").to(function(){
checkAuth();
});

Path.map("#/disconnect").to(function(){
$('#pageBody').empty();
var loggedIn = false;
var $workspace = false;
location.hash = '#/login';
});

Path.root("#/login");

Path.rescue(notFound);

$(document).ready(function() {
Path.listen();
});

@awj100
Copy link

awj100 commented Apr 17, 2013

I have a fix for this. I'll see if I can get my head around how to push the fix back to the developer of Pathjs.

In the meantime, here it is if you want to paste it into your local copy. Change line 180 to the following:

result = Path.routes.defined[this.path].do_enter[i].apply(this, arguments || []);

@jwbworks
Copy link
Author

still have the same issue where once the user steps from success to workspace the page refreshes and clears out the hash. Then the default path sends it back to login. This happens on ie7 - 9

If i go directly to the workspace hash it works fine. Is there an issue of changing the hash with on clicks or in a function call?

Also I am using path with require.js. Any issues doing that?

@vkatoch2000
Copy link

any idea how we can make it work on IE 7 to 9

@arian
Copy link

arian commented Sep 17, 2013

#50 fixes the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants