-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameter m0 (reference moment tensor) missing in plot_cdf #274
Comments
Good catch, thanks Felix.
…On Tue, Sep 17, 2024 at 8:47 PM Félix Rodríguez Cardozo < ***@***.***> wrote:
The subroutine plot_cdf
<https://github.com/rmodrak/mtuq/blob/2a558a7181c784a6b6956e01323d16b4d45d7b29/mtuq/graphics/uq/omega.py#L51>
requires the reference moment tensor parameter m0 for calling
_calculate_pdf
<https://github.com/rmodrak/mtuq/blob/2a558a7181c784a6b6956e01323d16b4d45d7b29/mtuq/graphics/uq/omega.py#L75>
.
Currently, it will show the error:
omega, pdf = _calculate_pdf(df, var, m0=m0, nbins=nbins, NameError: name
'm0' is not defined
—
Reply to this email directly, view it on GitHub
<#274>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCGSSVT33E5Z56EXMWXO7DZXDSTZAVCNFSM6AAAAABOMWBBO2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGUZTENJXGU2TSNI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Will add this to next PR.
…On Tue, Sep 17, 2024 at 10:33 PM Ryan Modrak ***@***.***> wrote:
Good catch, thanks Felix.
On Tue, Sep 17, 2024 at 8:47 PM Félix Rodríguez Cardozo <
***@***.***> wrote:
> The subroutine plot_cdf
> <https://github.com/rmodrak/mtuq/blob/2a558a7181c784a6b6956e01323d16b4d45d7b29/mtuq/graphics/uq/omega.py#L51>
> requires the reference moment tensor parameter m0 for calling
> _calculate_pdf
> <https://github.com/rmodrak/mtuq/blob/2a558a7181c784a6b6956e01323d16b4d45d7b29/mtuq/graphics/uq/omega.py#L75>
> .
>
> Currently, it will show the error:
>
> omega, pdf = _calculate_pdf(df, var, m0=m0, nbins=nbins, NameError: name
> 'm0' is not defined
>
> —
> Reply to this email directly, view it on GitHub
> <#274>, or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABCGSSVT33E5Z56EXMWXO7DZXDSTZAVCNFSM6AAAAABOMWBBO2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGUZTENJXGU2TSNI>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The subroutine plot_cdf requires the reference moment tensor parameter
m0
for calling _calculate_pdf.Currently, it will show the error:
omega, pdf = _calculate_pdf(df, var, m0=m0, nbins=nbins, NameError: name 'm0' is not defined
The text was updated successfully, but these errors were encountered: