Also protect against session.gc_maxlifetime <= 0

michael-grunder · michael-grunder · commit 7a79ad9c27b1 · 2020-01-10T09:47:58.000-08:00
Addresses phpredis#1694
diff --git a/redis_session.c b/redis_session.c
@@ -127,6 +127,9 @@ static int session_gc_maxlifetime() {
     if (value > INT_MAX) {
         php_error_docref(NULL, E_NOTICE, "session.gc_maxlifetime overflows INT_MAX, truncating.");
         return INT_MAX;
+    } else if (value <= 0) {
+        php_error_docref(NULL, E_NOTICE, "session.gc_maxlifetime is <= 0, defaulting to 1440 seconds");
+        return 1440;
     }
 
     return value;

Original file line number	Diff line number	Diff line change
`@@ -127,6 +127,9 @@ static int session_gc_maxlifetime() {`
`127`	`127`	`if (value > INT_MAX) {`
`128`	`128`	`php_error_docref(NULL, E_NOTICE, "session.gc_maxlifetime overflows INT_MAX, truncating.");`
`129`	`129`	`return INT_MAX;`
	`130`	`+ } else if (value <= 0) {`
	`131`	`+ php_error_docref(NULL, E_NOTICE, "session.gc_maxlifetime is <= 0, defaulting to 1440 seconds");`
	`132`	`+ return 1440;`
`130`	`133`	`}`
`131`	`134`
`132`	`135`	`return value;`