-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Toolbar] Add Toolbar components #1349
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
f2b6d91
to
9c3111f
Compare
2901a4d
to
61dc192
Compare
5dcde0c
to
5fe85d2
Compare
I found a strange behavior: the menu won't close when a submenu is open and you move the roving focus to the next toolbar element by pressing ➡️. Only the submenu is closed. See attached video. Kapture.2025-02-07.at.07.45.58.mp4 |
This comment was marked as outdated.
This comment was marked as outdated.
090aee3
to
b3d1c0c
Compare
c865bad
to
626f251
Compare
736a277
to
7b40b0c
Compare
52068e8
to
557bbd4
Compare
557bbd4
to
c7b0c97
Compare
OK it turns out various triggers have issues with the disabled state when they are not native The fix depends on #1445 Before some of these experiments seemed to work occasionally because I was passing the disabled state 2-3 times, to the trigger, the root, and the toolbar button at the same time, but it should only be passed once to the toolbar button |
Docs:
https://deploy-preview-1349--base-ui.netlify.app/react/components/toolbar
Demos:
Summary
Root
,Button
,Input
,Link
,Group
,Separator
focusableWhenDisabled
prop onButton
&Input
orientation
proploop
prophotkey prop on Root[Toolbar] Support an optional hotkey #1454cols
propComponent integrations
The three demos linked above show all of these:
Toolbar.Input
Inputthis will be aToolbar.Input
insteadCloses #661