-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dialog] Dialogs should adjust position when mobile keyboard is open #1455
Comments
Hey @borabaloglu in our docs demo, the Popup just has |
I think both of these are caused by the iOS scroll locking solution from
|
Hey @mj12albert, All three examples I attached use I’ve encountered issues with |
@borabaloglu pinch zooming doesn't work on iOS currently either with our solution, but it does work on every other platform |
Looks like it has other issues on iOS:
Further, Maybe an issue can be filed on the React Aria repo for this, instead? Worst case, we just don't lock scroll on iOS at all because there are always so many issues with it 😖 (Tried to create a repro with RA alone but it freezes as a standalone page on CodeSandbox) |
Feature request
Summary
Dialogs on mobile could be more responsive, particularly in handling input fields. This is not limited to dialogs but applies broadly to modals. The document should adjust its position dynamically to keep the input field visible when the keyboard is open.
Additionally, there's a noticeable jumping effect when the keyboard appears, which affects the user experience. This behavior is demonstrated in the attached video.
I’ve included three examples from Base UI, 9ui (my project built on top of Base UI), and shadcn/ui to illustrate how other libraries handle this.
Examples in other libraries
https://github.com/user-attachments/assets/95f7dbfd-f401-468f-8d05-17a7c448213e (Base UI)
https://github.com/user-attachments/assets/68efb3b7-431e-4758-82de-2b85c6cc236b (9ui)
https://github.com/user-attachments/assets/c761bbb1-22c0-43df-ac2b-c58c1c538958 (shadcn/ui)
Motivation
Enhancing the user experience on mobile devices. This feature would primarily benefit mobile users and developers building mobile-first applications, ensuring smoother interactions when dealing with modals and input fields.
The text was updated successfully, but these errors were encountered: