Skip to content
/ mui-x Public
  • Sponsor mui/mui-x

  • Notifications You must be signed in to change notification settings
  • Fork 1.4k

Commit 721b285

Browse files
alexfauquetteLukasTy
andauthoredNov 26, 2024··
[charts] Flatten imports from @mui/utils and @mui/system (#15603)
Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com> Co-authored-by: Lukas Tyla <llukas.tyla@gmail.com>
1 parent 3fa5b49 commit 721b285

File tree

11 files changed

+26
-31
lines changed

11 files changed

+26
-31
lines changed
 

‎.eslintrc.js

+12-11
Original file line numberDiff line numberDiff line change
@@ -59,21 +59,22 @@ const RESTRICTED_TOP_LEVEL_IMPORTS = [
5959
const buildPackageRestrictedImports = (packageName, root, allowRootImports = true) => [
6060
{
6161
files: [`packages/${root}/src/**/*{.ts,.tsx,.js}`],
62-
excludedFiles: ['*.d.ts', '*.spec.ts', '*.spec.tsx', '**.test.tx', '**.test.tsx'],
62+
excludedFiles: [
63+
'*.d.ts',
64+
'*.spec.ts',
65+
'*.spec.tsx',
66+
'**.test.tx',
67+
'**.test.tsx',
68+
`packages/${root}/src/index{.ts,.tsx,.js}`,
69+
],
6370
rules: {
6471
'no-restricted-imports': [
6572
'error',
6673
{
67-
paths: [
68-
{
69-
name: packageName,
70-
message: 'Use relative import instead',
71-
},
72-
{
73-
name: '@mui/material',
74-
message: 'Use @mui/utils or a more specific import instead',
75-
},
76-
],
74+
paths: RESTRICTED_TOP_LEVEL_IMPORTS.map((pkName) => ({
75+
name: pkName,
76+
message: 'Use relative import instead',
77+
})),
7778
patterns: [
7879
// TODO move rule into main repo to allow deep @mui/monorepo imports
7980
{

‎packages/x-charts-pro/src/BarChartPro/BarChartPro.tsx

+1-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import * as React from 'react';
33
import PropTypes from 'prop-types';
44
import { useThemeProps } from '@mui/material/styles';
5-
import { BarChartProps, BarPlot } from '@mui/x-charts/BarChart';
5+
import { BarPlotProps, BarChartProps, BarPlot } from '@mui/x-charts/BarChart';
66
import { ChartsOnAxisClickHandler } from '@mui/x-charts/ChartsOnAxisClickHandler';
77
import { ChartsGrid } from '@mui/x-charts/ChartsGrid';
88
import { ChartsOverlay } from '@mui/x-charts/ChartsOverlay';
@@ -12,7 +12,6 @@ import { ChartsAxisHighlight } from '@mui/x-charts/ChartsAxisHighlight';
1212
import { ChartsTooltip } from '@mui/x-charts/ChartsTooltip';
1313
import { ChartsClipPath } from '@mui/x-charts/ChartsClipPath';
1414
import { useBarChartProps } from '@mui/x-charts/internals';
15-
import { BarPlotProps } from '@mui/x-charts';
1615
import { ChartContainerPro } from '../ChartContainerPro';
1716
import { ZoomSetup } from '../context/ZoomProvider/ZoomSetup';
1817
import { useZoom } from '../context/ZoomProvider/useZoom';

‎packages/x-charts-pro/src/ChartContainerPro/ChartContainerPro.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import type {} from '../typeOverloads';
55
import { Watermark } from '@mui/x-license/Watermark';
66
import { ChartContainerProps } from '@mui/x-charts/ChartContainer';
77
import { ResizableContainer } from '@mui/x-charts/internals';
8-
import { ChartsSurface } from '@mui/x-charts';
8+
import { ChartsSurface } from '@mui/x-charts/ChartsSurface';
99
import { getReleaseInfo } from '../internals/utils/releaseInfo';
1010
import { ChartDataProviderPro } from '../context/ChartDataProviderPro';
1111
import { ZoomProps } from '../context/ZoomProvider';

‎packages/x-charts-pro/src/Heatmap/heatmapClasses.ts

+2-4
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
import {
2-
unstable_generateUtilityClass as generateUtilityClass,
3-
unstable_generateUtilityClasses as generateUtilityClasses,
4-
} from '@mui/utils';
1+
import generateUtilityClass from '@mui/utils/generateUtilityClass';
2+
import generateUtilityClasses from '@mui/utils/generateUtilityClasses';
53

64
export interface HeatmapClasses {
75
/** Styles applied to the heatmap cells. */

‎packages/x-charts-pro/src/LineChartPro/LineChartPro.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import {
1010
LinePlot,
1111
LinePlotProps,
1212
MarkPlot,
13+
MarkPlotProps,
1314
} from '@mui/x-charts/LineChart';
1415
import { ChartsOnAxisClickHandler } from '@mui/x-charts/ChartsOnAxisClickHandler';
1516
import { ChartsGrid } from '@mui/x-charts/ChartsGrid';
@@ -20,7 +21,6 @@ import { ChartsLegend } from '@mui/x-charts/ChartsLegend';
2021
import { ChartsTooltip } from '@mui/x-charts/ChartsTooltip';
2122
import { ChartsClipPath } from '@mui/x-charts/ChartsClipPath';
2223
import { useLineChartProps } from '@mui/x-charts/internals';
23-
import { MarkPlotProps } from '@mui/x-charts';
2424
import { ChartContainerPro } from '../ChartContainerPro';
2525
import { ZoomSetup } from '../context/ZoomProvider/ZoomSetup';
2626
import { useZoom } from '../context/ZoomProvider/useZoom';

‎packages/x-charts-pro/src/context/CartesianProviderPro/createAxisFilterMapper.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ import {
88
isDefined,
99
getScale,
1010
} from '@mui/x-charts/internals';
11-
import { ChartsAxisProps, ScaleName, AxisConfig } from '@mui/x-charts';
11+
import { ScaleName, AxisConfig } from '@mui/x-charts/models';
12+
import { ChartsAxisProps } from '@mui/x-charts/ChartsAxis';
1213
import { ZoomData } from '../ZoomProvider';
1314

1415
type CreateAxisFilterMapperParams = {

‎packages/x-charts-pro/src/internals/utils/releaseInfo.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { ponyfillGlobal } from '@mui/utils';
1+
import ponyfillGlobal from '@mui/utils/ponyfillGlobal';
22

33
export const getReleaseInfo = () => {
44
const releaseInfo = '__RELEASE_INFO__';

‎packages/x-charts/src/ChartsAxis/axisClasses.ts

+2-4
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
import {
2-
unstable_generateUtilityClass as generateUtilityClass,
3-
unstable_generateUtilityClasses as generateUtilityClasses,
4-
} from '@mui/utils';
1+
import generateUtilityClass from '@mui/utils/generateUtilityClass';
2+
import generateUtilityClasses from '@mui/utils/generateUtilityClasses';
53

64
export interface ChartsAxisClasses {
75
/** Styles applied to the root element. */

‎packages/x-charts/src/ChartsLegend/chartsLegendClasses.ts

+2-4
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
import {
2-
unstable_generateUtilityClass as generateUtilityClass,
3-
unstable_generateUtilityClasses as generateUtilityClasses,
4-
} from '@mui/utils';
1+
import generateUtilityClass from '@mui/utils/generateUtilityClass';
2+
import generateUtilityClasses from '@mui/utils/generateUtilityClasses';
53

64
export interface ChartsLegendClasses {
75
/** Styles applied to the root element. */

‎packages/x-charts/src/ChartsTooltip/ChartsTooltipTable.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { styled } from '@mui/material/styles';
2-
import { shouldForwardProp } from '@mui/system';
2+
import { shouldForwardProp } from '@mui/system/createStyled';
33
import { chartsTooltipClasses } from './chartsTooltipClasses';
44

55
/**

‎packages/x-charts/src/models/axis.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import type {
99
ScaleSequential,
1010
ScaleThreshold,
1111
} from '@mui/x-charts-vendor/d3-scale';
12-
import { SxProps } from '@mui/system';
12+
import { SxProps } from '@mui/system/styleFunctionSx';
1313
import { ChartsAxisClasses } from '../ChartsAxis/axisClasses';
1414
import type { TickParams } from '../hooks/useTicks';
1515
import { ChartsTextProps } from '../ChartsText';

0 commit comments

Comments
 (0)
Please sign in to comment.