[data grid] pagination has unexpected behavior using -1 for "All" rows per page

[Drewpeifer]

Steps to reproduce

Steps:

1. Open this link to live example: mui-x data-grid-pro Page Size Options example
2. Set rows per page to 25
3. Navigate to page 2 of results (26-50)
4. Set rows per page to "All"

Current behavior

In the example above, the rows disappear from table.

I have seen other behavior too selecting All when it's set to -1, such as the table showing a misc subset of rows, or showing the proper row count - 1.

Expected behavior

All of the rows should be shown in the table. My solution was to use the length of the rows array instead of -1 for "All".

Context

I was trying to display a dynamic setting for all rows without having to calculate it. For that purpose, it would be nice if displaying the "All" option was just a grid prop, e.g. allowAllRows, and was computed using the length of the rows array passed to the table. Maybe there's a limitation I don't know about though.

Your environment

N/A, bug is visible in docs example

Search keywords: data-grid page pagination all rows

[MBilalShafi]

I can reproduce the bug. To fix it, we need to reset the page to the first one whenever the pageSize is set to -1, the following diff seems to fix it:

diff --git a/packages/x-data-grid/src/hooks/features/pagination/useGridPaginationModel.ts b/packages/x-data-grid/src/hooks/features/pagination/useGridPaginationModel.ts
index c331fa6af6..fca83c2b2f 100644
--- a/packages/x-data-grid/src/hooks/features/pagination/useGridPaginationModel.ts
+++ b/packages/x-data-grid/src/hooks/features/pagination/useGridPaginationModel.ts
@@ -41,7 +41,7 @@ export const getDerivedPaginationModel = (
     paginationModel = paginationModelProp;
   }
 
-  const validPage = getValidPage(paginationModel.page, pageCount);
+  const validPage = pageSize === -1 ? 0 : getValidPage(paginationModel.page, pageCount);
   if (validPage !== paginationModel.page) {
     paginationModel = { ...paginationModel, page: validPage };
   }

Feel free to open up a PR since this is fairly straight-forward.