-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge for deployment testing #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Body의 방 설정 정보(RoomSettings)를 참고하여 새로운 방을 생성합니다.
각 IP는 최대 1개의 방을 hosting 할 수 있습니다.
새로운 방 생성에 성공하면 room code를 반환합니다.
RoomStorage → RedisStorage
SESSION_CODE → SESSION_COOKIE_NAME
min-coverage-overall을 80에서 70으로 변경하였습니다.
요청 데이터에서 오류가 발생한 경우에 대한 예제를 추가합니다. (BindException.class)
요청 데이터에서 오류가 발생한 경우에 대한 예제를 추가합니다. (BindException.class)
세션 쿠키를 갖고 있다는 것은 이미 방에 참가 중임을 암시합니다. 따라서 새로운 방을 생성할 수 없습니다.
세션 쿠키를 갖고 있다는 것은 이미 방에 참가 중임을 암시합니다. 따라서 새로운 방을 생성할 수 없습니다.
feature: 방 만들기 기능 구현 완료
Add configuration for test job with Redis service and script to copy application.yml files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.