Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percussion panel - reset layout doesn't work with Muse Sounds drumsets #26353

Open
4 tasks done
mathesoncalum opened this issue Feb 5, 2025 · 0 comments
Open
4 tasks done
Assignees
Labels
P1 Priority: High percussion Pertaining to percussion instruments (notation or playback) Pre-release feature issue This pertains to a new feature and should be addressed prior to release UI Visual issues affecting the UI (not notation)

Comments

@mathesoncalum
Copy link
Contributor

Issue type

UI bug (incorrect info or interface appearance)

Description with steps to reproduce

  1. Create a score with a percussion instrument
  2. Switch to a Muse Sounds drumset in the mixer
  3. Click Layout -> Reset layout in the percussion panel toolbar
  4. Layout is incorrect

Supporting files, videos and screenshots

resetlayout.mov

What is the latest version of MuseScore Studio where this issue is present?

Master

Regression

No.

Operating system

All

Additional context

I am reasonably certain that the cause of this is PercussionPanelModel::resetLayout using the current Instrument's ID to resolve an InstrumentTemplate. This is a problem because the ID won't necessarily correlate to the sound chosen in the mixer.

Checklist

  • This report follows the guidelines for reporting bugs and issues
  • I have verified that this issue has not been logged before, by searching the issue tracker for similar issues
  • I have attached all requested files and information to this report
  • I have attempted to identify the root problem as concisely as possible, and have used minimal reproducible examples where possible
@mathesoncalum mathesoncalum added the percussion Pertaining to percussion instruments (notation or playback) label Feb 5, 2025
@mathesoncalum mathesoncalum self-assigned this Feb 5, 2025
@muse-bot muse-bot added the UI Visual issues affecting the UI (not notation) label Feb 5, 2025
@zacjansheski zacjansheski added the P1 Priority: High label Feb 6, 2025
@zacjansheski zacjansheski added the Pre-release feature issue This pertains to a new feature and should be addressed prior to release label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Priority: High percussion Pertaining to percussion instruments (notation or playback) Pre-release feature issue This pertains to a new feature and should be addressed prior to release UI Visual issues affecting the UI (not notation)
Projects
Status: To do
Development

No branches or pull requests

3 participants