Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with httpx 0.28.0 #1446

Open
decaz opened this issue Nov 29, 2024 · 8 comments · May be fixed by #1447
Open

Incompatibility with httpx 0.28.0 #1446

decaz opened this issue Nov 29, 2024 · 8 comments · May be fixed by #1447

Comments

@decaz
Copy link

decaz commented Nov 29, 2024

Since version 0.28.0 of httpx The deprecated proxies argument has now been removed.:

self.wsdl_client = wsdl_client or httpx.Client(
verify=verify_ssl,
proxies=proxy,
timeout=timeout,
)
self.client = client or httpx.AsyncClient(
verify=verify_ssl,
proxies=proxy,
timeout=operation_timeout,
)

@decaz decaz changed the title Incompatibilty with httpx Incompatibilty with httpx 0.28.0 Nov 29, 2024
@decaz decaz changed the title Incompatibilty with httpx 0.28.0 Incompatibility with httpx 0.28.0 Nov 30, 2024
@TB99930
Copy link

TB99930 commented Dec 11, 2024

If anyone is experiencing this problem, simply fix your version of httpx, using an exact version pre-0.28 or the qualifier <0.28 until the attached PR is merged.

For example: httpx>=0.26,<0.28 or httpx==0.27.2

@ba1dr
Copy link

ba1dr commented Dec 11, 2024

If anyone is experiencing this problem, simply fix your version of httpx, using an exact version pre-0.28 or the qualifier <0.28 until the attached PR is merged.

For example: httpx>=0.26,<0.28 or httpx==0.27.2

I think this is a bad solution, as other libraries may require newer version or have another constraint.
Perhaps we can just initialize clients outside and pass to the Transport's constructor:

wsdl_client = httpx.Client(
    verify=sslcontext,
    timeout=HTTP_TIMEOUT,
)
httpx_client = httpx.AsyncClient(verify=sslcontext,
                                 timeout=HTTP_TIMEOUT)
transport = AsyncTransport(client=httpx_client, wsdl_client=wsdl_client)
zclient = ZeepClient(
    wsdl_file, transport=transport,
    service_name=bind_soap_service, port_name=bind_soap_port
)

@kostyaten
Copy link

When will the update be?

@PrieJos
Copy link

PrieJos commented Jan 23, 2025

Hi @ba1dr

Could you please at least tell us whether there is any plan to fix this incompatibility issue or not?

Thanks
Jose M. Prieto

@ba1dr
Copy link

ba1dr commented Jan 29, 2025

Hi @ba1dr

Could you please at least tell us whether there is any plan to fix this incompatibility issue or not?

Thanks Jose M. Prieto

I literally have no idea, as I am just the same user of this library as you. Looking at the past releases timeline I can only conclude that the author is busy and this library is semi-abandoned.

Perhaps eventually this will be fixed, but at the moment the best we can do is either override this issue with one of the examples above or make a fork and fix it for yourself.

@PrieJos
Copy link

PrieJos commented Jan 29, 2025

Hi @ba1dr

Oops, sorry for that. I don’t know why I came to the conclusion you were the developer. My apologies.

Perhaps eventually this will be fixed, but at the moment the best we can do is either override this issue with one of the examples above or make a fork and fix it for yourself.

Fully agree with you. Let’s see.

Cheers
José M Prieto

@K3str3l
Copy link

K3str3l commented Feb 6, 2025

If anyone is experiencing this problem, simply fix your version of httpx, using an exact version pre-0.28 or the qualifier <0.28 until the attached PR is merged.

For example: httpx>=0.26,<0.28 or httpx==0.27.2

If I understand correctly, I tried both of the above suggestions in the manifest.json in the \config\custom_components\kingspan_watchman_sensit folder, but each time I restarted after the change the intergration I receive an error.
Do I need to download a file from "somewhere"?

thanks in advance for any direction

@masaccio
Copy link

masaccio commented Feb 7, 2025

If anyone is experiencing this problem, simply fix your version of httpx, using an exact version pre-0.28 or the qualifier <0.28 until the attached PR is merged.

For example: httpx>=0.26,<0.28 or httpx==0.27.2

That doesn’t work for Home Assistant for example which requires latest httpx. The code from @ba1dr works well and it’s what I am doing in my HA integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants