get_ppid 2 is not 1

[antalk2]

x11docker/x11docker

Line 917 in 8357d94

get_ppid() { # get ppid of pid $1

get_ppid 2 returns a large number. I guess it sums the ppids of all pids containing 2

Possible replacement:

get_ppid() {
    local pid_to_check="${1:empty_pid}"
    local res=''
    res="$( $Myps ax -o pid,ppid                  \
           | grep -E '^\s+'"${pid_to_check}"'\s+' \
           | awk ' { print $2 } '
         )"
    if [ -z "$res" ] ; then
        echo "" # what should be printed here?
        return 1
    else
        echo "$res"
        return 0
    fi
}

[antalk2]

Checking in my system, ppid of pid 2 is 0, so the title above may be wrong.

[mviereck]

You are doing a quite well review of the code, thank you very much!
Would you be interested to become a maintainer?
I am rarely working at x11docker nowadays, and it could deserve someone who looks after it and keeps it up to date.
Then you could directly push your edits.

[antalk2]

local pid_to_check="${1:empty_pid}"

This is wrong, (missing dash after the colon) should be local pid_to_check="${1:-empty_pid}"

Would you be interested to become a maintainer?
Then you could directly push your edits.

Risky.

• I never used bash this heavily, many features used in x11docker I have never seen before.
• I do not have access to Mac, or even to an uptodate windows (for WSL)

I can create pull requests, for the smaller changes, and show my edits in a fork on github.

Most of the edits concern readability (indentation, comments, limiting line length),
and many cond && a || b rewrites to if-then-else. Nevertheless they may introduce bugs,
and readability for me is not necessarily considered an improvement by others.

Would these (pull requests + visible fork) help?

On bugs: I am trying to use https://bashunit.com/assertions#assert-exec to test some functions.
But on the larger (e.g. application) level, I am not sure how to do that. I mean automated testing,
to catch mistakes.