Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types are apparently wrong for Node16 #90

Open
rhys-vdw opened this issue Feb 16, 2025 · 3 comments
Open

Types are apparently wrong for Node16 #90

rhys-vdw opened this issue Feb 16, 2025 · 3 comments

Comments

@rhys-vdw
Copy link

https://arethetypeswrong.github.io/?p=leac%400.6.0

For Node16, apparently you need to provide a leac.d.mts and leac.d.cts instead of just .d.ts.

I couldn't get it to work in my project, and asked in TypeScript Community discord. So I'm not really across what exactly is going on here, but that is apparently the problem.

@KillyMXI
Copy link
Member

Hello and thank you for your interest in the project.

I'm aware that there are compatibility issues with Node16 and up.
I intend to address it as much as I can in the next version, but I'm not sure when I can publish it.
New version of peberminta, which I consider a companion package to this, is far from done, and I don't want too much difference between published versions.

Maybe I can publish leac as a preview version in the meanwhile.
It will declare Node20 as the supported version though. Node18 is at the tail end of its support period and a pain to target when most of infrastructure packages already moved on. By the time I'm able to finish with peberminta - it will certainly be over.

Iirc, I had some issues trying to generate leac.d.cts.
But if https://github.com/arethetypeswrong/arethetypeswrong.github.io says it is a thing - I'll have to take another look.

@KillyMXI
Copy link
Member

I just published 0.7.0-preview.1

ATTW is green: https://arethetypeswrong.github.io/?p=leac%400.7.0-preview.1

Let me know if there are any remaining issues.

It will stay in preview until peberminta is also ready to be updated.

@rhys-vdw
Copy link
Author

rhys-vdw commented Mar 4, 2025

Sorry I actually moved to moo so I won't be able to test with my project! I'm sure the change will be helpful for others though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants