Skip to content

Plugin API missing clientUpdateByPrimaryKeyMethodGenerated method for dynamic SQL runtime #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
octoape opened this issue Dec 14, 2023 · 4 comments
Milestone

Comments

@octoape
Copy link
Contributor

octoape commented Dec 14, 2023

The plugin API is missing the clientUpdateByPrimaryKeyMethodGenerated method of the dynamic SQL runtime, and the callPlugins method of the UpdateByPrimaryKeyMethodGenerator class calls the clientUpdateByPrimaryKeyWithBLOBsMethodGenerated method.

@jeffgbutler
Copy link
Member

I realize this is confusing.

There are two plugin methods "clientUpdateByPrimaryKeyWithoutBLOBsMethodGenerated" and "clientUpdateByPrimaryKeyWithBLOBsMethodGenerated". My thinking about it was that the dynamic SQL runtime does not make a distinction between "with BLOBs" and "without BLOBs", so the "with BLOBs" plugin method was accurate in all cases - the "without BLOBs" method would be inaccurate if the class actually had BLOB fields.

@octoape
Copy link
Contributor Author

octoape commented Dec 16, 2023

OK, understood.
Is it possible to add a clientUpdateByPrimaryKeyMethodGenerated method and call it in the UpdateByPrimaryKeyMethodGenerator class callPlugins method.
For compatibility clientUpdateByPrimaryKeyMethodGenerated calls clientUpdateByPrimaryKeyWithBLOBsMethodGenerated method by default.

@jeffgbutler
Copy link
Member

This is a good idea.

@jeffgbutler
Copy link
Member

Resolved via #1118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants