💥 no-missing-require/import recognize node: prefix

As requested in #275, recognize Node.js core modules referenced using
the [`node:`](https://nodejs.org/api/esm.html#esm_node_imports) URL
scheme.

Since `resolve.isCore` was moved to `is-core-module` in
browserify/resolve@7c26483
and `[email protected]` added support for `node:` in
inspect-js/is-core-module@7341223
require `is-core-module@^2.3.0`.

Note: `is-core-module` checks whether the module is supported in a given
Node.js version (if not provided, the current version is checked).
Although checking whether a name is a core module in all Node.js
versions supported by the package would be ideal, it will require
significantly more design and implementation work and is therefore not
included in this commit.

Fixes: #275

Signed-off-by: Kevin Locke <[email protected]>

Author: kevinoid

lib/util/visit-import.js

@@ -5,7 +5,7 @@
 "use strict"
 
 const path = require("path")
-const resolve = require("resolve")
+const isCoreModule = require("is-core-module")
 const getResolvePaths = require("./get-resolve-paths")
 const getTryExtensions = require("./get-try-extensions")
 const ImportTarget = require("./import-target")
@@ -53,7 +53,8 @@ module.exports = function visitImport(
             }
 
             const name = sourceNode && stripImportPathParams(sourceNode.value)
-            if (name && (includeCore || !resolve.isCore(name))) {
+            // Note: "999" arbitrary to check current/future Node.js version
+            if (name && (includeCore || !isCoreModule(name, "999"))) {
                 targets.push(new ImportTarget(sourceNode, name, options))
             }
         },

lib/util/visit-require.js

@@ -6,7 +6,7 @@
 
 const path = require("path")
 const { CALL, ReferenceTracker, getStringIfConstant } = require("eslint-utils")
-const resolve = require("resolve")
+const isCoreModule = require("is-core-module")
 const getResolvePaths = require("./get-resolve-paths")
 const getTryExtensions = require("./get-try-extensions")
 const ImportTarget = require("./import-target")
@@ -48,7 +48,8 @@ module.exports = function visitRequire(
                 const targetNode = node.arguments[0]
                 const rawName = getStringIfConstant(targetNode)
                 const name = rawName && stripImportPathParams(rawName)
-                if (name && (includeCore || !resolve.isCore(name))) {
+                // Note: "999" arbitrary to check current/future Node.js version
+                if (name && (includeCore || !isCoreModule(name, "999"))) {
                     targets.push(new ImportTarget(targetNode, name, options))
                 }
             }

package.json

@@ -16,6 +16,7 @@
     "eslint-plugin-es": "^4.1.0",
     "eslint-utils": "^2.0.0",
     "ignore": "^5.1.1",
+    "is-core-module": "^2.3.0",
     "minimatch": "^3.0.4",
     "resolve": "^1.10.1",
     "semver": "^6.1.0"

tests/lib/rules/no-missing-import.js

@@ -47,6 +47,10 @@ ruleTester.run("no-missing-import", rule, {
             filename: fixture("test.js"),
             code: "import fs from 'fs';",
         },
+        {
+            filename: fixture("test.js"),
+            code: "import fs from 'node:fs';",
+        },
         {
             filename: fixture("test.js"),
             code: "import eslint from 'eslint/lib/api';",

tests/lib/rules/no-missing-require.js

@@ -25,6 +25,11 @@ ruleTester.run("no-missing-require", rule, {
             code: "require('fs');",
             env: { node: true },
         },
+        {
+            filename: fixture("test.js"),
+            code: "require('node:fs');",
+            env: { node: true },
+        },
         {
             filename: fixture("test.js"),
             code: "require('eslint');",