some TODOs removed

n7space · Aug 8, 2018 · a5696dd · a5696dd
1 parent c00c9dc
commit a5696dd
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 12 deletions.
diff --git a/src/acneditor.cpp b/src/acneditor.cpp
@@ -62,7 +62,7 @@ AcnEditorFactory::AcnEditorFactory()
     setIndenterCreator([]() { return new Indenter; });
     setAutoCompleterCreator([]() { return new Completion::AutoCompleter; });
 
-    addHoverHandler(new TextEditor::BaseHoverHandler); // TODO maybe better tips?
+    addHoverHandler(new TextEditor::BaseHoverHandler);
 
     setCodeFoldingSupported(true);
     setMarksVisible(true);
@@ -77,5 +77,5 @@ AcnEditorFactory::AcnEditorFactory()
 
 void AcnEditorWidget::findUsages()
 {
-    // TODO acn
+    // TODO #166
 }
diff --git a/src/asn1sccserviceprovider.cpp b/src/asn1sccserviceprovider.cpp
@@ -94,7 +94,7 @@ void Asn1SccServiceProvider::start()
     m_stayAliveTimer.start();
     m_asn1sccService->start();
 
-    if (!m_asn1sccService->waitForStarted()) // TODO handle error?
+    if (!m_asn1sccService->waitForStarted())
         Messages::messageProcessError(m_asn1sccService);
 }
 
@@ -107,7 +107,7 @@ void Asn1SccServiceProvider::stop()
     m_stayAliveTimer.stop();
     m_asn1sccService->terminate();
 
-    if (!m_asn1sccService->waitForFinished()) // TODO handle error?
+    if (!m_asn1sccService->waitForFinished())
         Messages::messageProcessError(m_asn1sccService);
 }
 
@@ -170,7 +170,7 @@ QJsonDocument Asn1SccServiceProvider::buildAstRequestData(
     input["AcnFiles"] = acnFilesArray;
 
     /* TODO: since AST parser is not ready to work with fields introduced through ACN files,
-     * it is harmful to include them in daemon call*/
+     * it is harmful to include them in daemon call (#169)*/
     input["AcnFiles"] = QJsonArray();
 
     input["Options"] = buildAstGenerationOptions();

diff --git a/src/asneditor.cpp b/src/asneditor.cpp
@@ -67,7 +67,7 @@ AsnEditorFactory::AsnEditorFactory()
     setAutoCompleterCreator([]() { return new Completion::AutoCompleter; });
     setIndenterCreator([]() { return new Indenter; });
 
-    addHoverHandler(new TextEditor::BaseHoverHandler); // TODO maybe better hover tips?
+    addHoverHandler(new TextEditor::BaseHoverHandler);
 
     setCodeFoldingSupported(true);
     setMarksVisible(true);

diff --git a/src/completion/autocompleter.cpp b/src/completion/autocompleter.cpp
@@ -45,8 +45,6 @@ bool AutoCompleter::isInComment(const QTextCursor &cursor) const
 
 bool AutoCompleter::isInString(const QTextCursor &cursor) const
 {
-    // TODO: multiline strings in ASN?
-    // TODO: escaping string?
     QTextCursor moved = cursor;
     moved.movePosition(QTextCursor::StartOfLine);
     const int positionInLine = cursor.position() - moved.position();

diff --git a/src/editor.cpp b/src/editor.cpp
@@ -93,8 +93,6 @@ void EditorWidget::contextMenuEvent(QContextMenuEvent *e)
 
 void EditorWidget::finalizeInitialization()
 {
-    // TODO ? setLanguageSettingsId(Constants::SettingsId);
-
     auto document = qobject_cast<Document *>(textDocument());
     connect(document,
             &Document::extraSelectionsUpdated,

diff --git a/src/projectcontenthandler.cpp b/src/projectcontenthandler.cpp
@@ -87,13 +87,12 @@ void ProjectContentHandler::handleFileContentChanged(const Utils::FileName &path
 {
     QStringList projects = m_storage->getProjectsForFile(path);
 
-    // TODO: Is this conditions still needed?
     if (projects.empty()) {
         allProcessingFinished();
         return;
     }
 
-    for (const QString projectName : projects) {
+    for (const QString &projectName : projects) {
         const auto paths = m_storage->getFilesPathsFromProject(projectName);
         processFiles(projectName, paths);
     }