Fix Coderabbit issues and add P4 to Azure build

Author: AdrianSoundy

CMake/Modules/ESP32_P4_GCC_options.cmake

@@ -21,7 +21,7 @@ macro(nf_set_compile_options)
     target_compile_options(${NFSCO_TARGET} PUBLIC ${NFSCO_EXTRA_COMPILE_OPTIONS} -Wall -Wextra -Werror -Wno-sign-compare -Wno-unused-parameter -Wshadow -Wimplicit-fallthrough -fshort-wchar -fno-builtin -fno-common -fno-exceptions -fcheck-new )
 
     # this series has FPU 
-    target_compile_definitions(${NFSCO_TARGET} PUBLIC -DTARGET=esp32c6 -DUSE_FPU=TRUE -DPLATFORM_ESP32 -DESP_PLATFORM) 
+    target_compile_definitions(${NFSCO_TARGET} PUBLIC -DTARGET=esp32p4 -DUSE_FPU=TRUE -DPLATFORM_ESP32 -DESP_PLATFORM) 
 
 endmacro()
 

azure-pipelines.yml

@@ -516,6 +516,15 @@ jobs:
           PackageName: ESP32_S3_ALL
           CMakePreset: ESP32_S3_ALL
 
+        ESP32_P4_UART:
+          TargetBoard: ESP32_P4
+          TargetSeries: "esp32p4"
+          BuildOptions:
+          IDF_Target: esp32p4
+          TargetName: ESP32_P4_UART
+          PackageName: ESP32_P4_UART
+          CMakePreset: ESP32_P4_UART
+
         ESP32_ETHERNET_KIT_1.2:
           TargetBoard: ESP32
           TargetSeries: "esp32"

targets/ESP32/ESP32_P4/nanoCLR/nanoFramework.Graphics/Spi_To_TouchPanel.cpp

@@ -5,9 +5,8 @@
 
 #define UNUSED(x) (void)x
 
-#ifndef SPI_TO_TOUCHPANEL_H
-#define SPI_TO_TOUCHPANEL_H
-
+#ifndef SPI_TO_TOUCHPANEL_CPP
+#define SPI_TO_TOUCHPANEL_CPP
 #include "nanoCLR_Types.h"
 #include <nanoPAL.h>
 #include <target_platform.h>

targets/ESP32/_IDF/sdkconfig.default.esp32s2

@@ -8,7 +8,6 @@ CONFIG_IDF_TARGET="esp32s2"
 # Deprecated drivers, disable warnings on build
 CONFIG_ADC_SUPPRESS_DEPRECATE_WARN=y
 CONFIG_ADC_CALI_SUPPRESS_DEPRECATE_WARN=y
-CONFIG_UART_ISR_IN_IRAM=y
 CONFIG_PCNT_SUPPRESS_DEPRECATE_WARN=y
 CONFIG_RMT_SUPPRESS_DEPRECATE_WARN=y
 CONFIG_I2S_SUPPRESS_DEPRECATE_WARN=y