style : cs fixes from rector

Author: prisis

Cache.php

@@ -42,15 +42,17 @@ public function read($file)
     {
         $content = parent::read($file);
 
-        if ($this->tagsManager !== null && \is_string($content) && $this->tagsManager->hasProvider($file) && \is_array($data = \json_decode($content, true))) {
-            $content = \json_encode($this->removeLegacyTags($data));
+        if ($this->tagsManager !== null && \is_string($content) && $this->tagsManager->hasProvider($file) && \is_array($data = \json_decode($content, true, 512, \JSON_THROW_ON_ERROR))) {
+            $content = \json_encode($this->removeLegacyTags($data), \JSON_THROW_ON_ERROR);
         }
 
         return $content;
     }
 
     /**
      * Helper to remove legacy tags.
+     *
+     * @return mixed[]
      */
     public function removeLegacyTags(array $data): array
     {

ComposerRepository.php

@@ -60,6 +60,8 @@ protected function loadProviderListings($data): void
 
     /**
      * {@inheritdoc}
+     *
+     * @return mixed|mixed[]
      */
     protected function fetchFile($filename, $cacheKey = null, $sha256 = null, $storeLastModifiedTime = false): array
     {

LegacyTagsManager.php

@@ -51,9 +51,6 @@ final class LegacyTagsManager implements LegacyTagsManagerContract
     /** @var null|array */
     private $versions;
 
-    /**
-     * Create a new LegacyTagsManager instance.
-     */
     public function __construct(IOInterface $io, Downloader $downloader)
     {
         $this->io = $io;
@@ -205,6 +202,7 @@ public function reset(): void
     }
 
     /**
+     * @param array<string, array<string, array<int, string>>>                                   $versions
      * @param \Composer\Semver\Constraint\Constraint|\Composer\Semver\Constraint\MultiConstraint $symfonyConstraint
      */
     private function getVersions(array $versions, $symfonyConstraint): array

Plugin.php

@@ -45,7 +45,7 @@
 use Symfony\Component\Console\Input\ArgvInput;
 use Symfony\Component\Console\Input\InputInterface;
 
-class Plugin implements EventSubscriberInterface, PluginInterface
+final class Plugin implements EventSubscriberInterface, PluginInterface
 {
     /** @var string */
     public const VERSION = '0.13.1';
@@ -56,12 +56,20 @@ class Plugin implements EventSubscriberInterface, PluginInterface
     /** @var string */
     public const PACKAGE_NAME = 'narrowspark/automatic-composer-prefetcher';
 
+    public $providerRepos;
+
+    public $repositoryClasses;
+
+    public $repositories;
+
+    public $config;
+
     /**
      * A Container instance.
      *
      * @var \Narrowspark\Automatic\Common\Contract\Container
      */
-    protected $container;
+    private $container;
 
     /**
      * Check if the the plugin is activated.
@@ -123,6 +131,8 @@ public function activate(Composer $composer, IOInterface $io): void
 
     /**
      * {@inheritdoc}
+     *
+     * @return mixed[][][]|string[]
      */
     public static function getSubscribedEvents(): array
     {
@@ -147,7 +157,7 @@ public function onPreDependenciesSolving(InstallerEvent $event): void
         $listed = [];
         $packages = [];
         $pool = $event->getPool();
-        $pool = Closure::bind(function () {
+        $pool = Closure::bind(function (): Pool {
             foreach ($this->providerRepos as $k => $repo) {
                 $this->providerRepos[$k] = new class($repo) extends BaseComposerRepository {
                     /**
@@ -164,8 +174,10 @@ public function __construct(RepositoryInterface $repo)
 
                     /**
                      * {@inheritdoc}
+                     *
+                     * @return mixed[]
                      */
-                    public function whatProvides(Pool $pool, $name, $bypassFilters = false)
+                    public function whatProvides(Pool $pool, $name, $bypassFilters = false): array
                     {
                         $packages = [];
 
@@ -260,8 +272,8 @@ private function configureLegacyTagsManager(
             }
 
             $this->addLegacyTags($io, $requires, $tagsManager);
-        } elseif (isset($extra[static::COMPOSER_EXTRA_KEY]['require'])) {
-            $this->addLegacyTags($io, $extra[static::COMPOSER_EXTRA_KEY]['require'], $tagsManager);
+        } elseif (isset($extra[self::COMPOSER_EXTRA_KEY]['require'])) {
+            $this->addLegacyTags($io, $extra[self::COMPOSER_EXTRA_KEY]['require'], $tagsManager);
         }
     }
 

Prefetcher.php

@@ -29,6 +29,15 @@
 
 final class Prefetcher implements PrefetcherContract
 {
+    /** @var array */
+    private const REPO_READING_COMMANDS = [
+        'create-project' => true,
+        'outdated' => true,
+        'require' => true,
+        'update' => true,
+        'install' => true,
+    ];
+
     /**
      * The composer io implementation.
      *
@@ -92,15 +101,6 @@ final class Prefetcher implements PrefetcherContract
      */
     private $cacheDirPopulated = false;
 
-    /** @var array */
-    private static $repoReadingCommands = [
-        'create-project' => true,
-        'outdated' => true,
-        'require' => true,
-        'update' => true,
-        'install' => true,
-    ];
-
     /**
      * Create a new PreFetcher instance.
      */
@@ -148,12 +148,12 @@ public function prefetchComposerRepositories(): void
         $command = $this->input->getFirstArgument();
 
         if ($this->populateRepoCacheDir === true
-            && isset(self::$repoReadingCommands[$command])
+            && isset(self::REPO_READING_COMMANDS[$command])
             && ($command !== 'install' || (\file_exists(Factory::getComposerFile()) && ! \file_exists(Util::getComposerLockFile())))
         ) {
             $repos = [];
 
-            foreach ($this->composer->getPackage()->getRepositories() as $name => $repo) {
+            foreach ($this->composer->getPackage()->getRepositories() as $repo) {
                 if (! isset($repo['type']) || $repo['type'] !== 'composer' || ! empty($repo['force-lazy-providers'])) {
                     continue;
                 }
@@ -179,15 +179,15 @@ public function prefetchComposerRepositories(): void
      */
     public function fetchAllFromOperations($event): void
     {
-        if ($this->cacheDirPopulated === true || $this->getDryRun() === true) {
+        if ($this->cacheDirPopulated || $this->getDryRun()) {
             return;
         }
 
         $this->cacheDirPopulated = true;
 
         $downloads = [];
 
-        foreach ($event->getOperations() as $i => $operation) {
+        foreach ($event->getOperations() as $operation) {
             switch ($operation->getJobType()) {
                 case 'install':
                     $package = $operation->getPackage();
@@ -245,7 +245,7 @@ private static function getUrlFromPackage(PackageInterface $package): ?string
     {
         $fileUrl = $package->getDistUrl();
 
-        if (! $fileUrl) {
+        if ($fileUrl === '') {
             return null;
         }
 
@@ -281,10 +281,6 @@ function (PackageInterface $package, $processedUrl) {
      */
     private function getDryRun(): bool
     {
-        if ($this->input->hasParameterOption('--dry-run')) {
-            return true;
-        }
-
-        return false;
+        return $this->input->hasParameterOption('--dry-run');
     }
 }