Merge pull request #5 from PrisisForks/feature/remove-not-needed-code

fix : removing mistake with old php bug fix

Author: prisis

.build/phpstan-baseline.neon

@@ -15,11 +15,6 @@ parameters:
 			count: 1
 			path: ../src/FrameCollection.php
 
-		-
-			message: "#^Parameter \\#1 \\$frame of method Narrowspark\\\\ExceptionInspector\\\\Inspector\\:\\:isValidNextFrame\\(\\) expects array\\('file' \\=\\> string\\|null, 'line' \\=\\> int\\|null, 'class' \\=\\> string, 'args' \\=\\> array, 'function' \\=\\> string\\|null\\), array\\<string, mixed\\> given\\.$#"
-			count: 1
-			path: ../src/Inspector.php
-
 		-
 			message: "#^Parameter \\#1 \\$frames of class Narrowspark\\\\ExceptionInspector\\\\FrameCollection constructor expects array\\<int, array\\<string, array\\<string, mixed\\>\\|int\\|string\\|null\\>\\>, array\\<int, array\\<string, array\\<string\\>\\|int\\|string\\>\\> given\\.$#"
 			count: 1

.github/workflows/mutation.yml

@@ -24,8 +24,8 @@ jobs:
 
     env:
       key: "mutation-v1" # change key (version) to clear cache
-      min-covered-msi: 70
-      min-msi: 60
+      min-covered-msi: 75
+      min-msi: 63
       extensions: "mbstring"
       ini-values: "date.timezone=Europe/Berlin, opcache.enable_cli=1, pcov.directory=api"
       tools: "composer, composer-prefetcher, cs2pr"

composer.json

@@ -64,7 +64,7 @@
         ],
         "cs": "composer --working-dir=./.build cs -- -v",
         "cs:check": "composer --working-dir=./.build cs:check -- -v",
-        "infection": "composer --working-dir=./.build infection -- --min-covered-msi=70 --min-msi=60",
+        "infection": "composer --working-dir=./.build infection -- --min-covered-msi=75 --min-msi=63",
         "phpstan": "composer --working-dir=./.build phpstan -- --memory-limit=-1",
         "phpstan:baseline": "composer --working-dir=./.build phpstan:baseline -- --memory-limit=-1",
         "psalm": "composer --working-dir=./.build psalm",

src/Inspector.php

@@ -72,25 +72,6 @@ public function getFrames(): FrameCollection
         if ($this->frames === null) {
             $frames = $this->getTrace($this->exception);
 
-            // Fill empty line/file info for call_user_func_array usages (PHP Bug #44428)
-            foreach ($frames as $k => $frame) {
-                if ($frame['file'] !== '') {
-                    // Default values when file and line are missing
-                    $file = '[internal]';
-                    $line = 0;
-
-                    $nextFrame = $frames[$k + 1] ?? [];
-
-                    if ($this->isValidNextFrame($nextFrame)) {
-                        $file = $nextFrame['file'];
-                        $line = $nextFrame['line'];
-                    }
-
-                    $frames[$k]['file'] = $file;
-                    $frames[$k]['line'] = $line;
-                }
-            }
-
             // Find latest non-error handling frame index ($i) used to remove error handling frames
             $i = 0;
 
@@ -316,23 +297,6 @@ private function getFrameFromException(Throwable $exception): array
         ];
     }
 
-    /**
-     * Determine if the frame can be used to fill in previous frame's missing info
-     * happens for call_user_func and call_user_func_array usages (PHP Bug #44428).
-     *
-     * @psalm-param array{file: ?string, line: ?int, class: string, args: array<array-key, mixed>, function: ?string} $frame
-     *
-     * @param array<string, array|int|string> $frame
-     */
-    private function isValidNextFrame(array $frame): bool
-    {
-        if (! isset($frame['file'], $frame['line'])) {
-            return false;
-        }
-
-        return isset($frame['function']) && stripos($frame['function'], 'call_user_func') !== false;
-    }
-
     /**
      * Determine if an error level is fatal (halts execution).
      */