Skip to content

Commit 3a3de10

Browse files
authored
xfail cudf argmin / argmax (#1599)
1 parent 30ff0b8 commit 3a3de10

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed

tests/expr_and_series/arg_max_test.py

+7
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@ def test_expr_arg_max_expr(
1919
if "modin" in str(constructor):
2020
# TODO(unassigned): bug in modin?
2121
return
22+
if "cudf" in str(constructor):
23+
# not implemented yet
24+
request.applymarker(pytest.mark.xfail)
2225
df = nw.from_native(constructor(data))
2326
df = nw.maybe_set_index(df, "i")
2427
result = df.select(nw.col("a", "b", "z").arg_max())
@@ -31,10 +34,14 @@ def test_expr_arg_max_series(
3134
constructor_eager: ConstructorEager,
3235
col: str,
3336
expected: float,
37+
request: pytest.FixtureRequest,
3438
) -> None:
3539
if "modin" in str(constructor_eager):
3640
# TODO(unassigned): bug in modin?
3741
return
42+
if "cudf" in str(constructor_eager):
43+
# not implemented yet
44+
request.applymarker(pytest.mark.xfail)
3845
series = nw.from_native(constructor_eager(data), eager_only=True)[col]
3946
series = nw.maybe_set_index(series, index=[1, 0, 9]) # type: ignore[arg-type]
4047
result = series.arg_max()

tests/expr_and_series/arg_min_test.py

+7
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@ def test_expr_arg_min_expr(
1616
if "dask" in str(constructor):
1717
# This operation is row-order dependent so we don't support it for Dask
1818
request.applymarker(pytest.mark.xfail)
19+
if "cudf" in str(constructor):
20+
# not implemented yet
21+
request.applymarker(pytest.mark.xfail)
1922
df = nw.from_native(constructor(data))
2023
result = df.select(nw.col("a", "b", "z").arg_min())
2124
expected = {"a": [0], "b": [0], "z": [0]}
@@ -27,10 +30,14 @@ def test_expr_arg_min_series(
2730
constructor_eager: ConstructorEager,
2831
col: str,
2932
expected: float,
33+
request: pytest.FixtureRequest,
3034
) -> None:
3135
if "modin" in str(constructor_eager):
3236
# TODO(unassigned): bug in modin?
3337
return
38+
if "cudf" in str(constructor_eager):
39+
# not implemented yet
40+
request.applymarker(pytest.mark.xfail)
3441
series = nw.from_native(constructor_eager(data), eager_only=True)[col]
3542
series = nw.maybe_set_index(series, index=[1, 0, 9]) # type: ignore[arg-type]
3643
result = series.arg_min()

0 commit comments

Comments
 (0)