replace error message (#1280)

raisadz · web-flow · commit 9f8809c9e0c8 · 2024-10-29T10:48:16.000Z
diff --git a/narwhals/translate.py b/narwhals/translate.py
@@ -429,7 +429,7 @@ def _from_native_impl(  # noqa: PLR0915
     elif hasattr(native_object, "__narwhals_series__"):
         if not allow_series:
             if strict:
-                msg = "Please set `allow_series=True`"
+                msg = "Please set `allow_series=True` or `series_only=True`"
                 raise TypeError(msg)
             return native_object
         return Series(
@@ -477,7 +477,7 @@ def _from_native_impl(  # noqa: PLR0915
         pl = get_polars()
         if not allow_series:
             if strict:
-                msg = "Please set `allow_series=True`"
+                msg = "Please set `allow_series=True` or `series_only=True`"
                 raise TypeError(msg)
             return native_object
         return Series(
@@ -509,7 +509,7 @@ def _from_native_impl(  # noqa: PLR0915
     elif is_pandas_series(native_object):
         if not allow_series:
             if strict:
-                msg = "Please set `allow_series=True`"
+                msg = "Please set `allow_series=True` or `series_only=True`"
                 raise TypeError(msg)
             return native_object
         pd = get_pandas()
@@ -544,7 +544,7 @@ def _from_native_impl(  # noqa: PLR0915
         mpd = get_modin()
         if not allow_series:
             if strict:
-                msg = "Please set `allow_series=True`"
+                msg = "Please set `allow_series=True` or `series_only=True`"
                 raise TypeError(msg)
             return native_object
         return Series(
@@ -578,7 +578,7 @@ def _from_native_impl(  # noqa: PLR0915
         cudf = get_cudf()
         if not allow_series:
             if strict:
-                msg = "Please set `allow_series=True`"
+                msg = "Please set `allow_series=True` or `series_only=True`"
                 raise TypeError(msg)
             return native_object
         return Series(
@@ -611,7 +611,7 @@ def _from_native_impl(  # noqa: PLR0915
         pa = get_pyarrow()
         if not allow_series:
             if strict:
-                msg = "Please set `allow_series=True`"
+                msg = "Please set `allow_series=True` or `series_only=True`"
                 raise TypeError(msg)
             return native_object
         return Series(
diff --git a/tests/translate/from_native_test.py b/tests/translate/from_native_test.py
@@ -134,7 +134,12 @@ def test_series_only(obj: Any, context: Any) -> None:
     ("allow_series", "context"),
     [
         (True, does_not_raise()),
-        (False, pytest.raises(TypeError, match="Please set `allow_series=True`")),
+        (
+            False,
+            pytest.raises(
+                TypeError, match="Please set `allow_series=True` or `series_only=True`"
+            ),
+        ),
     ],
 )
 def test_allow_series(series: Any, allow_series: Any, context: Any) -> None:

Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,12 @@ def test_series_only(obj: Any, context: Any) -> None:`
`134`	`134`	`("allow_series", "context"),`
`135`	`135`	`[`
`136`	`136`	`(True, does_not_raise()),`
`137`		- (False, pytest.raises(TypeError, match="Please set `allow_series=True`")),
	`137`	`+ (`
	`138`	`+ False,`
	`139`	`+ pytest.raises(`
	`140`	+ TypeError, match="Please set `allow_series=True` or `series_only=True`"
	`141`	`+ ),`
	`142`	`+ ),`
`138`	`143`	`],`
`139`	`144`	`)`
`140`	`145`	`def test_allow_series(series: Any, allow_series: Any, context: Any) -> None:`