wip

Author: MarcoGorelli

narwhals/pandas_like/dataframe.py

@@ -7,10 +7,8 @@
 from typing import Literal
 
 from narwhals.spec import DataFrame as DataFrameT
-from narwhals.spec import GroupBy as GroupByT
 from narwhals.spec import IntoExpr
 from narwhals.spec import LazyFrame as LazyFrameProtocol
-from narwhals.spec import LazyGroupBy as LazyGroupByT
 from narwhals.spec import Namespace as NamespaceProtocol
 from narwhals.utils import evaluate_into_exprs
 from narwhals.utils import flatten_str
@@ -22,6 +20,8 @@
 
     from typing_extensions import Self
 
+    from narwhals.pandas_like.group_by_object import GroupBy
+    from narwhals.pandas_like.group_by_object import LazyGroupBy
     from narwhals.pandas_like.namespace import Namespace
 
 
@@ -97,7 +97,7 @@ def __dataframe_namespace__(
     def shape(self) -> tuple[int, int]:
         return self.dataframe.shape  # type: ignore[no-any-return]
 
-    def group_by(self, *keys: str | Iterable[str]) -> GroupByT:
+    def group_by(self, *keys: str | Iterable[str]) -> GroupBy:
         from narwhals.pandas_like.group_by_object import GroupBy
 
         return GroupBy(self, flatten_str(*keys), api_version=self.api_version)
@@ -244,7 +244,7 @@ def __lazyframe_namespace__(
             implementation=self._implementation,  # type: ignore[attr-defined]
         )
 
-    def group_by(self, *keys: str | Iterable[str]) -> LazyGroupByT:
+    def group_by(self, *keys: str | Iterable[str]) -> LazyGroupBy:
         from narwhals.pandas_like.group_by_object import LazyGroupBy
 
         return LazyGroupBy(self, flatten_str(*keys), api_version=self.api_version)

narwhals/pandas_like/group_by_object.py

@@ -6,7 +6,7 @@
 
 from narwhals.pandas_like.dataframe import LazyFrame
 from narwhals.spec import DataFrame as DataFrameT
-from narwhals.spec import GroupBy as GroupByT
+from narwhals.spec import GroupBy as GroupByProtocol
 from narwhals.spec import IntoExpr
 from narwhals.spec import LazyFrame as LazyFrameProtocol
 from narwhals.spec import LazyGroupBy as LazyGroupByT
@@ -18,7 +18,7 @@
 from narwhals.utils import parse_into_exprs
 
 
-class GroupBy(GroupByT):
+class GroupBy(GroupByProtocol):
     def __init__(self, df: DataFrameT, keys: list[str], api_version: str) -> None:
         self._df = df
         self._keys = list(keys)